-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] legacy JS interop optional via WasmEnableLegacyJsInterop - native #82834
[browser] legacy JS interop optional via WasmEnableLegacyJsInterop - native #82834
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsInitial work to make trim legacy interop from native code and JavaScript. Changes
Future work
|
688deac
to
f25546a
Compare
Please ensure none of these funcs are used by the jiterpreter (CI ideally will catch it but isn't guaranteed) |
@kg The rest of here should be just moving them into conditional block. I will re-base this on the other PR later. |
f25546a
to
4e5b832
Compare
# Conflicts: # src/mono/wasi/runtime/CMakeLists.txt
CI failure is #80619 |
Initial work to make trim legacy interop from native code and JavaScript.
Split off from #79622
Changes
WasmEnableLegacyJsInterop
MSBuild feature.WasmEnableLegacyJsInterop==false
will not make the JS smaller. That would be follow-up work.ENABLE_LEGACY_JS_INTEROP
in native codedriver.c
under#ifdef ENABLE_LEGACY_JS_INTEROP
mono_wasm_get_delegate_invoke_ref
andmono_wasm_box_primitive_ref
lower in the same file.mono_wasm_get_type_name
andmono_wasm_get_type_aqn
higher in the same file.mono_wasm_typed_array_new_ref
fromcorebindings.c
todriver.c
core_initialize_internals
tobindings_initialize_internals
and unified it withmono_initialize_internals
CORE_BINDINGS
definitionlegacy_c_functions
cwraps.ts
andcorebindings.c
anddotnet.es6.lib.js
are sorted in the same ordermono_method_resolve
toexport_internal_api
dotnet.es6.lib.js
driven my environment variables, so that it could be configured at dev machine build timeEmscriptenEnvVars
inWasmApp.Native.targets
wasm.proj
loadedFiles
from 'Module' toruntimeHelpers
Future work