Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce IL3000 and IL3001 from NativeAOT compiler #83253

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

vitek-karas
Copy link
Member

This also implements the suppression of the IL3002 on the affected methods both in the NativeAOT compiler and the analyzer.

Adds single-file specific tests which are skipped for the trimmer.

Fixes: #83088
Fixes: #82475

@ghost
Copy link

ghost commented Mar 10, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This also implements the suppression of the IL3002 on the affected methods both in the NativeAOT compiler and the analyzer.

Adds single-file specific tests which are skipped for the trimmer.

Fixes: #83088
Fixes: #82475

Author: vitek-karas
Assignees: vitek-karas
Labels:

area-NativeAOT-coreclr

Milestone: 8.0.0

This also implements the suppression of the IL3002 on the affected methods both in the NativeAOT compiler and the analyzer.

Adds single-file specific tests which are skipped for the trimmer.
@vitek-karas vitek-karas force-pushed the SingleFileIntrinsics branch from 42814a0 to 833b3ec Compare March 14, 2023 07:48
@vitek-karas
Copy link
Member Author

This is now ready for review. @sbomer you're probably the most familiar with the code affected by this change (mostly the shared bits and stuff around it).

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitek-karas vitek-karas merged commit 43acdf9 into dotnet:main Mar 15, 2023
@vitek-karas vitek-karas deleted the SingleFileIntrinsics branch March 15, 2023 09:38
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants