Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mono] Add more binary op intrinsics for ARM64 mini JIT #83337

Merged
merged 5 commits into from
Mar 15, 2023
Merged

[Mono] Add more binary op intrinsics for ARM64 mini JIT #83337

merged 5 commits into from
Mar 15, 2023

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Mar 13, 2023 •
edited
Loading

This PR enabled emitting hardware intrinsics for the following API of Vector/Vector128 for ARM64 mini JIT:

  • Subtract
  • BitwiseAnd
  • BitwiseOr
  • Xor
  • Operator + (one operand)
  • Operator - (one operand)
  • Operator ~
  • Operator +
  • Operator -
  • Operator &
  • Operator |
  • Operator ^

Contribute to #80566

@fanyang-mono fanyang-mono requested a review from jandupej March 13, 2023 16:09
@ghost ghost assigned fanyang-mono Mar 13, 2023
@fanyang-mono fanyang-mono changed the title [Mono] Add more binary op intrinsics for Arm64 mini JIT [Mono] Add more binary op intrinsics for ARM64 mini JIT Mar 13, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 13, 2023
Closed
@fanyang-mono
Copy link
Member Author

Test failure on runtime (Build Libraries Test Run release mono linux arm64 Debug) also happened on main.

jandupej
jandupej approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@jandupej jandupej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runfoapp runfoapp bot mentioned this pull request Mar 14, 2023
Closed
This was referenced Mar 14, 2023
Closed
Closed
Closed
@fanyang-mono
Copy link
Member Author

CI failures on wasm are not related to this PR.

@fanyang-mono fanyang-mono merged commit c0eb86a into dotnet:main Mar 15, 2023
@kotlarmilos kotlarmilos mentioned this pull request Mar 23, 2023
Closed
@kotlarmilos kotlarmilos mentioned this pull request Apr 4, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vargaz vargaz vargaz left review comments

@jandupej jandupej jandupej approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@fanyang-mono fanyang-mono

Labels
area-Codegen-Intrinsics-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanyang-mono @vargaz @jandupej