Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] JIT: fix bug in cloning conditions for jagged array (#83414) #83462

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[release/7.0] JIT: fix bug in cloning conditions for jagged array (#83414) #83462

merged 2 commits into from
Mar 31, 2023

Commits on Mar 15, 2023

  1. [release/7.0] JIT: fix bug in cloning conditions for jagged array (#8… 

    …3414)

Backport of #83414 to release/7.0, fixes #83242

When checking that an inner array access is in bounds, we must ensure any outer
access is fully in bounds too. We were checking that `idx < array.Len` but not
that `idx >= 0`.

Use an unsigned compare for this check so we can do both sides with a single
instruction.

Fixes #83242.
    @AndyAyersMS
    AndyAyersMS committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    5598ec5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/7.0' into Fix83242Backport

    @AndyAyersMS
    AndyAyersMS authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    01d8835 View commit details
    Browse the repository at this point in the history