-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISC-V] Port Mono for RISC-V 64 Arch (3/3) IL Lowering & Outputting #83716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xinlong-Wu
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
March 21, 2023 10:13
ghost
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Mar 21, 2023
This was referenced Mar 21, 2023
vargaz
reviewed
Mar 21, 2023
Looks ok, please fix the formatting to conform to the mono coding conventions, i.e. spaces before ( and { etc. Look for the other source files for examples. |
vargaz
approved these changes
Apr 3, 2023
it may conflicts again when second pr has been marged, I will resolve it then. |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-riscv
Related to the RISC-V architecture
area-VM-meta-mono
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches initially ported the JIT of MonoVM to
RISC-V 64 imafdc
Arch, withinglp64d
ABI.So that the runtime can run and output
hello world
to command line by MonoVM under these patchesThis patch lowering and output some IL instructions used during print "Hello World" based on the instructions of RISC-V64. In addition, it improves some logging info for debugging purposes.
ps. Only applying this patch may not compile successfully, splitting the patch is only for review purposes. more info please refer to #36748