Microsoft.NETCore.Platforms: support adding rids with '-' in the base part. #84413
Conversation
… part. Currently when trying to add a rid like 'linux-musl-x64' the rid is not understood to be base = 'linux-musl', arch = 'x64'. Instead the parser considers a potential optional qualifier. This causes the rid to be parsed as base = 'linux', arch = 'musl', and qualifier = 'x64'. We know the rids being added won't have a qualifier. If we take this into account while parsing, we can parse the rid correctly.
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsCurrently when trying to add a rid like 'linux-musl-x64' the rid is not understood to be base = 'linux-musl', arch = 'x64'. Instead the parser considers a potential optional qualifier. This causes the rid to be parsed as base = 'linux', arch = 'musl', and qualifier = 'x64'. We know the rids being added won't have a qualifier. If we take this into account while parsing, we can parse the rid correctly. @ericstj ptal. cc @ayakael
|
|
Interesting to know: os-release allows
|
…ection.cs Co-authored-by: Eric StJohn <[email protected]>
|
Thank you too for helping to get it fixed quickly @ericstj. |
|
Build failures are reported and unrelated to this PR. |
ghost
locked as resolved and limited conversation to collaborators
|
Do we need a 7.0 backport? |
|
/backport to release/7.0-staging |
|
Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4985461853 |
Currently when trying to add a rid like 'linux-musl-x64' the rid is not understood to be base = 'linux-musl', arch = 'x64'.
Instead the parser considers a potential optional qualifier. This causes the rid to be parsed as base = 'linux', arch = 'musl', and qualifier = 'x64'.
We know the rids being added won't have a qualifier. If we take this into account while parsing, we can parse the rid correctly.
@ericstj ptal.
cc @ayakael