Enable option to use the Windows ThreadPool #85373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andle.WindowsThreadPool.cs
…ativeOverlapped.WindowsThreadPool.cs
…dPoolPreAllocatedOverlapped.WindowsThreadPool.cs
jkotas
reviewed
Jun 1, 2023
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets
Outdated
Show resolved
Hide resolved
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 2, 2023
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…or WindowsThreadPool
eduardo-vp
force-pushed
the
feature/enable-windows-threadpool
branch
from
eb2c12b
to
3646176
Compare
eduardo-vp
force-pushed
the
feature/enable-windows-threadpool
branch
from
cff36df
to
56be9f1
Compare
kouvel
approved these changes
Jun 6, 2023
src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Unix.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Threading.ThreadPool/System.Threading.ThreadPool.sln
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on Windows, enable an option to switch between the Portable thread pool and the Windows thread pool.
This change targets NativeAOT, CoreCLR, and Mono.
Windows threadpool remains as the default for NativeAOT on Windows. For any other case the Portable thread pool remains the default.
Tests with the Windows thread pool enabled were added to the System.Threading.Threadpool solution.
Trimming is enabled to remove the unused thread pool.