Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0-staging] Microsoft.NETCore.Platforms: support adding rids with '-' in the base part. #86282

Merged
merged 2 commits into from
May 16, 2023
Merged

[release/7.0-staging] Microsoft.NETCore.Platforms: support adding rids with '-' in the base part. #86282

merged 2 commits into from
May 16, 2023

Commits on May 15, 2023

  1. Microsoft.NETCore.Platforms: support adding rids with '-' in the base… 

    … part.

Currently when trying to add a rid like 'linux-musl-x64'
the rid is not understood to be base = 'linux-musl', arch = 'x64'.

Instead the parser considers a potential optional qualifier.
This causes the rid to be parsed as base = 'linux', arch = 'musl',
and qualifier = 'x64'.

We know the rids being added won't have a qualifier. If we take
this into account while parsing, we can parse the rid correctly.
    @tmds
    tmds authored and github-actions committed May 15, 2023
    Configuration menu
    Copy the full SHA
    3b8e895 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/Microsoft.NETCore.Platforms/src/RuntimeGroupColl… 

    …ection.cs

Co-authored-by: Eric StJohn <[email protected]>
    @tmds @ericstj
    2 people authored and github-actions committed May 15, 2023
    Configuration menu
    Copy the full SHA
    9d98c1a View commit details
    Browse the repository at this point in the history