Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade build to use .NET 8 Preview 4 SDK #86408

Merged
merged 4 commits into from
May 19, 2023
Merged

Upgrade build to use .NET 8 Preview 4 SDK #86408

merged 4 commits into from
May 19, 2023

Conversation

jkoritzinsky
Copy link
Member

Update to use the new P4 SDK and fix a new diagnostic from MSBuild.

@jkoritzinsky
Upgrade build to use .NET 8 Preview 4 SDK
11c7856 
Update to use the new P4 SDK and fix a new diagnostic from MSBuild.
@ghost ghost assigned jkoritzinsky May 17, 2023
@ghost
Copy link

ghost commented May 17, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Update to use the new P4 SDK and fix a new diagnostic from MSBuild.

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure
Milestone: -

ViktorHofer
ViktorHofer approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the MSB4120 fix. Arcade updates the SDK with dotnet/arcade#13554

@jkoritzinsky
Copy link
Member Author

jkoritzinsky commented May 17, 2023 •
edited
Loading

@sbomer any ideas on the clang/linker/NativeAOT failures?

@layomia any ideas on the ConfigurationBinder generator failures?

(Build run for reference: https://github.com/dotnet/runtime/runs/13566791008)

This was referenced May 18, 2023
Open
Closed
@sbomer
Copy link
Member

sbomer commented May 18, 2023

I haven't checked, but it may be caused by https://github.com/dotnet/runtime/blob/3d7241ad46bc52677d5b5f3f4bcde93152c699a5/src/coreclr/tools/aot/ILCompiler/ILCompiler.csproj#L64C1-L65

@build-analysis build-analysis bot mentioned this pull request May 18, 2023
Closed
@jkoritzinsky
Copy link
Member Author

Failures are known. Announcement posted at #86517

@jkoritzinsky jkoritzinsky merged commit 5b869d8 into dotnet:main May 19, 2023
@jkoritzinsky jkoritzinsky deleted the p4 branch May 19, 2023 17:48
@build-analysis build-analysis bot mentioned this pull request May 20, 2023
Closed
3 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkoritzinsky @sbomer @ViktorHofer @hoyosjs