[mono][debugger] Support new JMC #86815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @thaystg Issue DetailsNot sure if this is the best approach yet, but for now is working.
|
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced May 29, 2023
|
/azp run runtime-wasm-dbgtests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 13, 2023
radical
reviewed
Jul 13, 2023
| g_assert (*step_thread_id); | ||
| err = get_object (*step_thread_id, (MonoObject**)&step_thread); | ||
| if (err != ERR_NONE) { | ||
| g_free (req); |
There was a problem hiding this comment.
curious - why is this freed in this code path, but not for the others in this function?
This was referenced Jul 20, 2023
|
@thaystg, are you still working on this? The last update was over a year ago. Should it be closed? |
|
We can close. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best approach yet, but for now is working.