Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore suppressed diagnostics in code fix verifier #88492

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Ignore suppressed diagnostics in code fix verifier #88492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/tools/illink/test/ILLink.RoslynAnalyzer.Tests/Verifiers/CSharpCodeFixVerifier`2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

using System.Collections.Generic;
using System.Collections.Immutable;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using ILLink.Shared;
Expand Down Expand Up @@ -36,6 +38,15 @@ public Test ()
return solution;
});
}

protected override ImmutableArray<(Project project, Diagnostic diagnostic)> SortDistinctDiagnostics (IEnumerable<(Project project, Diagnostic diagnostic)> diagnostics)
{
// Only include non-suppressed diagnostics in the result. Our tests suppress diagnostics
// with 'UnconditionalSuppressMessageAttribute', and expect them not to be reported.
return base.SortDistinctDiagnostics (diagnostics)
.Where (diagnostic => !diagnostic.diagnostic.IsSuppressed)
.ToImmutableArray ();
}
}

/// <inheritdoc cref="AnalyzerVerifier{TAnalyzer}.Diagnostic()"/>
Expand Down