Add new Pipeline for Running Libs Tests with TestReadyToRun #91229
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
ivdiazsa
added
area-Infrastructure-libraries
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFollows issue #85417. This is a follow up to PR #80946, which added the flag
|
global-build-job.yml, and disabled most pipelines to speed up the testing and debugging process.
the final bit to run them.
same build configuration, so adjusted that setting.
…rrent)' when TestReadyToRun is present, because we currently don't have 'net9.0' packages.
| <!-- | ||
| These tests are currently not R2R-Compatible, so we disable them whenever | ||
| we are using the TestReadyToRun flag. | ||
| --> | ||
| <ItemGroup Condition="'$(TestReadyToRun)' == 'true'"> | ||
| <Compile Remove="System\Runtime\JitInfoTests.cs" /> | ||
| <Compile Remove="System\Type\TypeTests.Get.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <!-- | ||
| This test surprisingly only fails on Linux and Windows when TestReadyToRun | ||
| is present. OSX runs just fine. | ||
| --> | ||
| <ItemGroup Condition="'$(TestReadyToRun)' == 'true' and ('$(TargetPlatformIdentifier)' == 'linux' or '$(TargetPlatformIdentifier)' == 'windows')"> | ||
| <Compile Remove="System\EnumTests.cs" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Do those tests fail to compile or successfully run? If the latter, do we have a way to determine at run time if we are testing crossgend bits?
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -103,6 +107,79 @@ | |||
| </ItemGroup> | |||
| </Target> | |||
|
|
|||
| <Target Name="ExcludeExistingR2RBinaries" | |||
There was a problem hiding this comment.
Please describe these targets via xml comments. I don't understand what the following targets are doing or why we need them so a comment would be appreciated: ExcludeExistingR2RBinaries, AddExistingR2RBinariesReferencesForCrossgen2, CopyExistingR2RBinaries and CopyLiveRefPackIfPresent.
There was a problem hiding this comment.
Agree with @ViktorHofer here - copies like this can cause extra work and even create incremental build issues when they use wildcards like this. It'd be good to understand them.
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
we know work, rather than trying to find all that don't work and disable them.
|
/azp run runtime-coreclr crossgen2 |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(RunSmokeTestsOnly)' != 'true' and '$(RunGrpcTestsOnly)' != 'true' and '$(RunHighAOTResourceRequiringTestsOnly)' != 'true' and '$(RunLimitedSetOfTests)' != 'true'"> | ||
| <ItemGroup Condition="'$(RunSmokeTestsOnly)' != 'true' |
There was a problem hiding this comment.
Please do not make this more complicated than it already is.
The existing ProjectExclusions ItemGroup should be exactly what you need here.
There was a problem hiding this comment.
Ok will change that. Just worth mentioning I thought you all didn't want to change that further because I originally disabled the bad tests with ProjectExclusions, and was told that was not the way to do it...
There was a problem hiding this comment.
I originally disabled the bad tests with
ProjectExclusions, and was told that was not the way to do it...
Can you point me to the comment asking not to use ProjectExclusion? I want to understand it.
There was a problem hiding this comment.
My bad, it was about disabling them in System.Runtime.Tests.csproj, not about ProjectExclusions. So many loops and very similar changes since this work was started I got confused for a second there.
not-working tests with ProjectExclusions.
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failure in the Windows pipeline is about something else after the test has run (i.e. unrelated to this PR). Details about these failures are described and tracked in issue #96035. The rest is clean, so merging this now. |
Follows issue #85417. This is a follow up to PR #80946, which added the flag
-p:TestReadyToRunfor running libraries tests with a crossgen'd runtime. This PR takes this new functionality and creates a new pipeline to have a way of regularly and consistently testing the libraries using ReadyToRun, extending our R2R/Crossgen2 coverage.