[release/8.0] Enable interceptors implicitly in binder gen nupkg when generator is enabled #91559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #91469 to release/8.0 /cc @layomia Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
layomia
requested review from
ericstj,
ViktorHofer,
tarekgh,
jeffhandley and
eiriktsarpalis
ViktorHofer
approved these changes
Sep 5, 2023
tarekgh
approved these changes
Sep 5, 2023
artl93
approved these changes
Sep 6, 2023
|
M2 approved. |
artl93
added
Servicing-approved
|
Failing test is #87552 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91469 to release/8.0
Corresponding web SDK change dotnet/sdk#35024
Customer Impact
The interceptors feature is required for source-gen to work; enable it implicitly on behalf of users NuGet package consumers that enable the generator.
Testing
Tested manually with local app.
Risk
Low: this is a tested update for nuget package impl of an off-by-default component.