[release/8.0] Fix downlevel build break in TensorPrimitives #92270
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsBackport of #92269 to release/8.0 /cc @stephentoub Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
| <ItemGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))"> | ||
| <Compile Include="System.Numerics.Tensors.netcore.cs" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
nit (only for the release/8.0 branch): The compile item's name is misleading as it applies to net7.0 and net8.0 only but net6.0 is also netcore.
There was a problem hiding this comment.
Good point, since this is more in the style realm, I'll let @michaelgsharp / @stephentoub / @tannergooding consider a rename here. #92219
There was a problem hiding this comment.
I'm having a hard time thinking of a better name. The suffix is really about the surface area it's targeting / being constrained to, which is the netstandard surface area. The fact that it's also being used in a build for a .NET Core TFM doesn't really matter, IMO.
There was a problem hiding this comment.
Let's address this request for GA. This is blocking the RC2 snap, so I merged it as-is.
|
This is approved/tell-mode to fix the build break, just as other infra work would be. Original work was already approved and this does not materially change that original PR. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #92269 to release/8.0
/cc @stephentoub
This fixes a build failure introduced by #92245 and only happening in release/8.0. As the original PR has already been approved, we can consider this tell-mode to fix the build failure.