Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] Generate valid llvm IR for the DivRem intrinsics. #92457

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Sep 22, 2023

Fixes #92455

@vargaz
Copy link
Contributor Author

vargaz commented Sep 22, 2023

Not sure why this is not hit by any of the CI test suites.

@vargaz vargaz requested a review from jandupej September 22, 2023 02:52
@fanyang-mono
Copy link
Member

Not sure why this is not hit by any of the CI test suites.

I would expect Build linux-x64 Release AllSubsets_Mono_LLVMAot_RuntimeTests llvmaot hit this, however, I took a brief look at the AOT log. It seems that it only aot'ed the test assemblies, not the BCL. I am not sure why. Need to look into it further.

@vargaz
Copy link
Contributor Author

vargaz commented Sep 22, 2023

Even the test assemblies should run into this problem, it happens for a line like:
X86Base.X64.DivRem ((ulong)i, (ulong)j, (ulong)k);

@vargaz vargaz merged commit 913231a into dotnet:main Sep 22, 2023
@vargaz vargaz deleted the llvm-divrem branch September 22, 2023 12:33
@vargaz
Copy link
Contributor Author

vargaz commented Sep 22, 2023

This could be backported to 8.0 although its unlikely to be encountered by users.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mono] LLVM AOT failed to compile System.Private.CoreLib.dll on amd64
3 participants