[QUIC] Improve checking WritesClosed #92580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsGives the Fixes #92350
|
ManickaP
force-pushed
the
mapichov/quic-fix-test
branch
from
ea2164f to
c2f6bb3
Compare
rzikm
reviewed
Sep 25, 2023
| Assert.True(stream.WritesClosed.IsCompleted); | ||
| try | ||
| { | ||
| await stream.WritesClosed.WaitAsync(TimeSpan.FromSeconds(5)); |
There was a problem hiding this comment.
should the await always throw in this case? Or is it nondeterministic?
There was a problem hiding this comment.
Non-deterministics as the comment above explains. It depends on timing of the peer, dispose might be called before all the data arrived ==> abort, or after ==> success. This is not just because we buffer the data, MsQuic has it's own layer of buffering that behaves the same way.
rzikm
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the
WritesClosedtask some time to finish and checks the result of the task itself.Fixes #92350