Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release config for Mono tests #99920

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Use release config for Mono tests #99920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1772,7 +1772,7 @@ extends:
jobParameters:
testGroup: innerloop
nameSuffix: Mono_Interpreter_LibrariesTests
buildArgs: -s mono+libs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true
buildArgs: -s mono+libs+libs.tests -rc Release -c $(_BuildConfig) /p:ArchiveTests=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you're still giving the option of choosing the -c for the runtime, even though -rc assumes Debug on libraries. They don't collide with each other, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this works fine. I generally prefer the explicitness of passing -c always in case we want to change it. It's not necessary here, just preference of explicitness (like the rest of the pipelines).

timeoutInMinutes: 480
# extra steps, run tests
postBuildSteps:
Expand Down Expand Up @@ -1804,7 +1804,7 @@ extends:
jobParameters:
testGroup: innerloop
nameSuffix: Mono_MiniJIT_LibrariesTests
buildArgs: -s mono+libs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true
buildArgs: -s mono+libs+libs.tests -rc Release -c $(_BuildConfig) /p:ArchiveTests=true
timeoutInMinutes: 480
# extra steps, run tests
postBuildSteps:
Expand Down
Loading