Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #78

Merged
merged 122 commits into from
Jul 19, 2024
Merged

[main] Update dependencies from dotnet/arcade #78

merged 122 commits into from
Jul 19, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 20, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 69ccaae5-538f-448b-d9ab-08db87e0b330
  • Build: 20240718.9
  • Date Produced: July 18, 2024 4:59:11 PM UTC
  • Commit: b4e499d1f6e6b3a981feabfed290d99261762382
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build
d9bb310 
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24168.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build
2bdbf5a 
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24170.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build
f3289fd 
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24171.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build
b2a9d6d 
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24172.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build
3210ec7 
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24172.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build
75e2f98 
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24172.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build
bc5e6b7 
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24175.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
99f86d3 
…326.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24176.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
c763b45 
…327.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24177.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
4243636 
…328.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24178.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
855e658 
…329.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24179.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
395b000 
…329.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24179.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
dd09f09 
…329.6

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24179.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
46034d5 
…403.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24203.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
192bdf7 
…403.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24203.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
ec5180c 
…403.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24203.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
29e50f8 
…405.14

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24205.14
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
0ece468 
…407.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24207.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
5ffe387 
…407.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24207.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
e61ac81 
…408.8

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24208.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
a0ccdb5 
…409.3

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24209.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
889e262 
…410.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24210.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
f257e1f 
…410.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24210.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
5498d6d 
…412.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24212.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
4d71c3c 
…412.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24212.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
31a07c7 
…412.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24212.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
a6ebda5 
…412.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24212.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
ee8221e 
…417.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24217.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
23b0bec 
…417.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24217.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
e34fd5b 
…419.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24219.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
e42e256 
…702.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24352.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
9916cea 
…702.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24352.2
@ViktorHofer
Copy link
Member

@joperezr please take a look

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
4a4e75d 
…702.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24352.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
34cd65c 
…710.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.1
@mmitche
Copy link
Member

mmitche commented Jul 10, 2024

@RussKie can you take a look while @joperezr is out?

@RussKie
Copy link
Member

RussKie commented Jul 10, 2024

@radical are you familiar with these failing tests?

@radical
Copy link
Member

radical commented Jul 10, 2024

@radical are you familiar with these failing tests?

nope, sorry!

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
73b836c 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
f4ce6a3 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
7cfa9d7 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
d8f499e 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
97440cd 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
f9860ac 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@joperezr
Copy link
Member

The error this is hitting is an issue with the SDK that has been fixed (worked around) in Aspire 8.0.1 and later versions, but this hasn't shipped in a newer SDK. @marcpopMSFT @dsplaisted has the fix for the duplicate workload entry concurrency issue been shipped in the SDK yet? If so we can probably just bump the global.json SDK version to unblock this PR.

@marcpopMSFT
Copy link
Member

The error this is hitting is an issue with the SDK that has been fixed (worked around) in Aspire 8.0.1 and later versions, but this hasn't shipped in a newer SDK. @marcpopMSFT @dsplaisted has the fix for the duplicate workload entry concurrency issue been shipped in the SDK yet? If so we can probably just bump the global.json SDK version to unblock this PR.

We never actually tracked down the issue as it was a multi-threading problem in the template engine that was only being triggered by Aspire. So once Aspire fixed it, we didn't keep digging (though vendors just found a new case of it we think but it requires automated template creation).

@dsplaisted
Copy link
Member

We never actually tracked down the issue as it was a multi-threading problem in the template engine that was only being triggered by Aspire. So once Aspire fixed it, we didn't keep digging (though vendors just found a new case of it we think but it requires automated template creation).

We did actually figure out the details of why this was happening: dotnet/templating#7946 (comment). However, it wasn't clear how to fix it correctly without impacting template engine perf, so it hasn't been fixed yet.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
156c402 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@marcpopMSFT
Copy link
Member

marcpopMSFT commented Jul 17, 2024 •
edited by ViktorHofer
Loading

We did actually figure out the details of why this was happening: dotnet/templating#7946 (comment). However, it wasn't clear how to fix it correctly without impacting template engine perf, so it hasn't been fixed yet.

Good point, my memory failed me.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
2562308 
…710.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24360.4
@akoeplinger
Copy link
Member

So what should we do? Disable the VerifyAspireTemplate test to unblock this PR?

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
337e687 
…718.9

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.24065.5 -> To Version 9.0.0-beta.24368.9
@mmitche
Copy link
Member

mmitche commented Jul 19, 2024

So what should we do? Disable the VerifyAspireTemplate test to unblock this PR?

That would be my preference.

@akoeplinger akoeplinger mentioned this pull request Jul 19, 2024
Open
@akoeplinger
Copy link
Member

@mmitche disabled the test and it's green now. I don't have permission to merge here though.

@mmitche mmitche enabled auto-merge (squash) July 19, 2024 21:05
@mmitche mmitche merged commit 692e333 into main Jul 19, 2024
10 checks passed
@mmitche mmitche deleted the darc-main-b43eec77-4ae9-453c-9727-99f3b13c400a branch July 19, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitche mmitche mmitche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mmitche @ViktorHofer @RussKie @radical @joperezr @marcpopMSFT @dsplaisted @akoeplinger @steveisok