Support strings in manifest versions #17329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
sfoslund
approved these changes
Apr 30, 2021
| @@ -4,67 +4,72 @@ | |||
| <body> | |||
| <trans-unit id="ConcreteWorkloadHasNoDescription"> | |||
| <source>Workload definition '{0}' is a concrete dev workload but has no description</source> | |||
| <target state="translated">워크로드 정의 '{0}'이(가) 구체적인 개발 워크로드이지만 설명이 없습니다.</target> | |||
| <target state="new">Workload definition '{0}' is a concrete dev workload but has no description</target> | |||
There was a problem hiding this comment.
Looks like we're losing some translations here
Check dependencies in workload manifests (dotnet#16746) * Implement workload manifest dependency validation * Test workload manifest dependency validation * Workload manifest version is now semver * Update projects that link/reference WorkloadManifestReader
dsplaisted
force-pushed
the
workload-manifest-string-version
branch
from
34d1d74
to
ff83aa9
Compare
This was referenced May 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #16746 to 5.0.3xx