[main] Update dependencies from dotnet/runtime #40189

dotnet-maestro · 2024-04-16T02:19:11Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
Build: 20240417.9
Date Produced: April 17, 2024 6:26:36 PM UTC
Commit: 4965f2160d927565f342184861ecfc20716317c6
Branch: refs/heads/main

Updates:
- Microsoft.Extensions.DependencyModel: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.Extensions.FileSystemGlobbing: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.Extensions.Logging: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.Extensions.Logging.Abstractions: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.Extensions.Logging.Console: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.NET.HostModel: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.NET.ILLink.Tasks: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.NETCore.App.Host.win-x64: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.NETCore.App.Ref: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.NETCore.App.Runtime.win-x64: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.NETCore.Platforms: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- System.CodeDom: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- System.Reflection.MetadataLoadContext: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- System.Resources.Extensions: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- System.Security.Cryptography.ProtectedData: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- System.ServiceProcess.ServiceController: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- System.Text.Encoding.CodePages: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- VS.Redist.Common.NetCore.SharedFramework.x64.9.0: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- VS.Redist.Common.NetCore.TargetingPack.x64.9.0: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.SourceBuild.Intermediate.runtime.linux-x64: from 9.0.0-preview.4.24215.5 to 9.0.0-preview.4.24217.9
- Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.4.24209.5 to 9.0.0-preview.4.24215.3
- Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.4.24209.5 to 9.0.0-preview.4.24215.3

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport: from 9.0.0-preview.4.24209.5 to 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.SourceBuild.Intermediate.emsdk: from 9.0.0-preview.4.24209.5 to 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64)

…0415.16 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24215.16

dotnet-maestro · 2024-04-16T02:29:19Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…0415.19 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24215.19

MichalStrehovsky · 2024-04-16T09:29:32Z

This is hitting various The feature 'params collections' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.. Likely from dotnet/runtime#100898

cc @stephentoub @jozkee

stephentoub · 2024-04-16T10:21:34Z

@AlekseyTs, if not using LangVersion Preview, why is the compiler considering params overloads that would only work with Preview and then failing because of them? Or am I misunderstanding what's happening here?

AlekseyTs · 2024-04-16T12:16:34Z

@stephentoub

Or am I misunderstanding what's happening here?

Usually, language version doesn't change how the code is interpreted, instead it causes an error if the version doesn't support a feature. There are exceptions to this rule, but not in case of params collection feature.

stephentoub · 2024-04-16T12:23:56Z

@stephentoub

Or am I misunderstanding what's happening here?

Usually, language version doesn't change how the code is interpreted, instead it causes an error if the version doesn't support a feature. There are exceptions to this rule, but not in case of params collection feature.

You're saying if someone is targeting C# 12 and calls M(someString) which had a params string[] overload and now also has a params ReadOnlySpan<string> overload, they'll no longer compile? That's prohibitive: we will be unable to use this feature.

AlekseyTs · 2024-04-16T12:30:40Z

You're saying if someone is targeting C# 12 and calls a method M(string) which had a params string[] overload and now also has a params ReadOnlySpan overload, they'll no longer compile?

I am saying that, if overload resolution picks a params collection overload and an earlier language version is targeted, an error is going to be reported. There is nothing new in this behavior. This is how language version works.

stephentoub · 2024-04-16T12:32:57Z

Then we can't use the new params span feature, at least not until that behavior is addressed. cc: @jaredpar

@jozkee, please revert the params span pr.

AlekseyTs · 2024-04-16T12:33:10Z

That's prohibitive: we will be unable to use this feature.

Feel free to propose a design change, if you have one on mind.

stephentoub · 2024-04-16T12:35:01Z

That's prohibitive: we will be unable to use this feature.

Feel free to propose a design change, if you have one on mind.

Don't consider the paramsness of an overload if that params won't work with the target language version.

AlekseyTs · 2024-04-16T12:37:28Z

Don't consider the paramsness of an overload if that params won't work with the target language version.

Could you submit this suggestion with motivating scenario as an issue?

…0416.2 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24216.2

jaredpar · 2024-04-16T15:54:56Z

I am saying that, if overload resolution picks a params collection overload and an earlier language version is targeted, an error is going to be reported. There is nothing new in this behavior. This is how language version works.

Agree this is how the language generally works here. It is a point I hadn't considered this when we were doing the design / implementation. That does run counter to the goal that this should be a drop in overload for existing places that use params T[].

There are exceptions to this rule, but not in case of params collection feature.

Think we are going to need to make an exception here. At a glance it seems like there are a few potential paths forward:

Don't issue a lang version warning on consumption, only on definition of params Span<T>.
Don't include params Span<T> in the candidate set when using a language version that doesn't support it.

My instinct is we should look at an approach like (1). There are times in the past where we've made pragmatic decisions to silence lang version warnings (enhanced #line for example). Can't think of a case off hand that we've done (2).

There are some LDM slots open next week that we could use to work through this.

AlekseyTs · 2024-04-16T17:47:12Z

I will add a placeholder to LDM agenda, but we really need an issue from @stephentoub to link to

jaredpar · 2024-04-16T19:08:12Z

I've been thinking about this a bit and have some ideas. I'll get an issue filed later today for us to link to.

…0416.7 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24216.7 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.4.24209.5 -> To Version 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

…0416.10 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24216.10 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.4.24209.5 -> To Version 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

…0416.16 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24216.16 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.4.24209.5 -> To Version 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

…0416.18 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24216.18 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.4.24209.5 -> To Version 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

…0417.1 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24217.1 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.4.24209.5 -> To Version 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

…0417.4 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24217.4 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.4.24209.5 -> To Version 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

lewing · 2024-04-17T16:03:42Z

The runtime params revert flow has reached here now

jaredpar · 2024-04-17T16:07:43Z

Filed the following issue to track us figuring out the lang version + params collection issue

dotnet/csharplang#8061

stephentoub · 2024-04-17T18:14:22Z

Thank you, @jaredpar.

…0417.9 Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24215.5 -> To Version 9.0.0-preview.4.24217.9 Dependency coherency updates Microsoft.NET.Workload.Emscripten.Current.Manifest-9.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk From Version 9.0.0-preview.4.24209.5 -> To Version 9.0.0-preview.4.24215.3 (parent: Microsoft.NETCore.App.Runtime.win-x64

dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Apr 16, 2024

jozkee mentioned this pull request Apr 16, 2024

Revert "Add params ReadOnlySpan<T> overloads" dotnet/runtime#101123

Merged

dotnet-maestro bot added 6 commits April 16, 2024 20:09

lewing approved these changes Apr 17, 2024

View reviewed changes

lewing enabled auto-merge (squash) April 17, 2024 20:02

lewing merged commit 3a98dda into main Apr 17, 2024
19 of 20 checks passed

lewing deleted the darc-main-bbd3a373-7df3-4f66-b30b-9cede83250b9 branch April 17, 2024 20:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/runtime #40189

[main] Update dependencies from dotnet/runtime #40189

dotnet-maestro bot commented Apr 16, 2024 •

edited

Loading

dotnet-maestro bot commented Apr 16, 2024

MichalStrehovsky commented Apr 16, 2024

stephentoub commented Apr 16, 2024 •

edited

Loading

AlekseyTs commented Apr 16, 2024

stephentoub commented Apr 16, 2024 •

edited

Loading

AlekseyTs commented Apr 16, 2024 •

edited

Loading

stephentoub commented Apr 16, 2024

AlekseyTs commented Apr 16, 2024

stephentoub commented Apr 16, 2024

AlekseyTs commented Apr 16, 2024

jaredpar commented Apr 16, 2024 •

edited

Loading

AlekseyTs commented Apr 16, 2024

jaredpar commented Apr 16, 2024

lewing commented Apr 17, 2024

jaredpar commented Apr 17, 2024

stephentoub commented Apr 17, 2024

[main] Update dependencies from dotnet/runtime #40189

[main] Update dependencies from dotnet/runtime #40189

Conversation

dotnet-maestro bot commented Apr 16, 2024 • edited Loading

From https://github.com/dotnet/runtime

Coherency Updates

dotnet-maestro bot commented Apr 16, 2024

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

MichalStrehovsky commented Apr 16, 2024

stephentoub commented Apr 16, 2024 • edited Loading

AlekseyTs commented Apr 16, 2024

stephentoub commented Apr 16, 2024 • edited Loading

AlekseyTs commented Apr 16, 2024 • edited Loading

stephentoub commented Apr 16, 2024

AlekseyTs commented Apr 16, 2024

stephentoub commented Apr 16, 2024

AlekseyTs commented Apr 16, 2024

jaredpar commented Apr 16, 2024 • edited Loading

AlekseyTs commented Apr 16, 2024

jaredpar commented Apr 16, 2024

lewing commented Apr 17, 2024

jaredpar commented Apr 17, 2024

stephentoub commented Apr 17, 2024

dotnet-maestro bot commented Apr 16, 2024 •

edited

Loading

stephentoub commented Apr 16, 2024 •

edited

Loading

stephentoub commented Apr 16, 2024 •

edited

Loading

AlekseyTs commented Apr 16, 2024 •

edited

Loading

jaredpar commented Apr 16, 2024 •

edited

Loading