Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/razor #41536

Merged
merged 27 commits into from
Jun 26, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 12, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/razor

  • Subscription: 5ba65a57-3ed4-48c1-1d9c-08dac299ead7
  • Build: 20240626.7
  • Date Produced: June 26, 2024 7:26:51 PM UTC
  • Commit: c4dd518d95a3b6ab7c52d35cac05833be58b29fd
  • Branch: refs/heads/main

…11.4

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24311.4
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Jun 12, 2024
v-wuzhai and others added 3 commits June 12, 2024 01:02
…12.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24312.1
…12.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24312.3
@Forgind
Copy link
Member

Forgind commented Jun 12, 2024

I'm seeing The specified RuntimeIdentifier 'centos.9-x64'

Can someone from @dotnet/source-build-contrib take a look?

@mthalman
Copy link
Member

The changes from dotnet/razor#10453 look suspicious. @ryzngard - please investigate.

…13.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24313.1
…13.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24313.3
…13.4

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24313.4
…16.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24316.1
…17.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24317.1
…17.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24317.3
…17.4

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24317.4
…17.5

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24317.5
…17.6

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24317.6
…17.7

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24317.7
@akoeplinger
Copy link
Member

@ryzngard ping :)

…19.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24319.1
@ryzngard
Copy link
Contributor

@ryzngard ping :)

Looking

@ryzngard
Copy link
Contributor

It looks like we need to do one of the following:

  1. Update the razor.proj to have conditional RID set similar to how Roslyn does it https://github.com/dotnet/dotnet/blob/b735d6e4857199630b5bb74739a545cb43cae77d/repo-projects/roslyn.proj#L20C5-L20C115

  2. Update rzls.csproj to ignore TargetRid for sourcebuild scenarios. It looks like that was what it did before.

I'm not familiar enough with sourcebuild to know which is the right answer. @akoeplinger @Forgind do you have a preference?

…19.2

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24319.2
dotnet-maestro bot and others added 4 commits June 20, 2024 09:54
…19.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24319.3
…20.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24320.1
…20.2

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24320.2
@akoeplinger
Copy link
Member

Looking at the diff you did set RuntimeIdentifier(s) to TargetRid when '$(DotNetBuild)' == 'true' before so it shouldn't have been ignored. Maybe it was because of the RidSpecificPublishNoBuildProperty which set NoBuild=true?

@dotnet/source-build-internal for the questions above

@ViktorHofer
Copy link
Member

Just to set expectations clear, without a fix ~today and getting that backported into 9.0 Preview 6, razor components will be 10 days old in the SDK. The last insertion commit into the SDK is dotnet/razor@0b7c3a0

@jjonescz
Copy link
Member

Just to set expectations clear, without a fix ~today and getting that backported into 9.0 Preview 6, razor components will be 10 days old in the SDK. The last insertion commit into the SDK is dotnet/razor@0b7c3a0

That sounds fine I think - that commit you pointed out is the most recent compiler fix we merged, others since then should be VS only (except for one FUSE fix but that's experimental).

…21.5

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24321.5
…21.9

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24321.9
…24.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24324.3
…25.1

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24325.1
…25.3

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24325.3
…25.5

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24325.5
…26.7

Microsoft.SourceBuild.Intermediate.razor , Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 9.0.0-preview.24311.2 -> To Version 9.0.0-preview.24326.7
@dotnet-maestro dotnet-maestro bot merged commit c84caf3 into main Jun 26, 2024
40 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-e7b12cc6-2e65-475a-9a27-ca762354c8de branch June 26, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants