Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Source-Build SDK Diff Tests Baselines and Exclusions #41929

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Update Source-Build SDK Diff Tests Baselines and Exclusions #41929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
929cf1f
Update baselines for build https://dev.azure.com/dnceng/internal/_bui…
dotnet-sb-bot Jul 2, 2024
9065ad7
Merge e2c1deb329d92fd4b0db3fb5b5423e9744c19188 into pr-baseline-20240…
dotnet-sb-bot Jul 3, 2024
b208803
Update baselines for build https://dev.azure.com/dnceng/internal/_bui…
dotnet-sb-bot Jul 3, 2024
41265a5
Merge 0adfe88b120123b22e17ef14fd5ef5826562d989 into pr-baseline-20240…
dotnet-sb-bot Jul 4, 2024
5bb1aec
Update baselines for build https://dev.azure.com/dnceng/internal/_bui…
dotnet-sb-bot Jul 4, 2024
7cfe46e
Merge 53d4e6658d9eefed6c350b67413ea0aa785d70cc into pr-baseline-20240…
dotnet-sb-bot Jul 5, 2024
a08702a
Merge f0884dc226c8121b4e771b0fe26268d48dd52596 into pr-baseline-20240…
dotnet-sb-bot Jul 8, 2024
cadd4f8
Update baselines for build https://dev.azure.com/dnceng/internal/_bui…
dotnet-sb-bot Jul 8, 2024
6d09bd1
Include library-packs in baseline + update diff
ellahathaway Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 15 additions & 63 deletions ...t/test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/ArtifactsSizeTests/centos.9-x64.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ Microsoft.AspNetCore.SignalR.Common.x.y.z.nupkg: 31619
Microsoft.AspNetCore.SignalR.Protocols.Json.x.y.z.nupkg: 25486
Microsoft.AspNetCore.WebUtilities.x.y.z.nupkg: 60948
Microsoft.Bcl.AsyncInterfaces.x.y.z.nupkg: 36212
Microsoft.Bcl.Cryptography.x.y.z.nupkg: 42370
Microsoft.Bcl.Cryptography.x.y.z.nupkg: 74957
ellahathaway marked this conversation as resolved.
Show resolved Hide resolved
Microsoft.Bcl.Memory.x.y.z.nupkg: 64143
ellahathaway marked this conversation as resolved.
Show resolved Hide resolved
Microsoft.Bcl.Numerics.x.y.z.nupkg: 30912
Microsoft.Bcl.TimeProvider.x.y.z.nupkg: 38239
Microsoft.Build.Framework.x.y.z.nupkg: 520138
Expand Down Expand Up @@ -86,7 +87,7 @@ Microsoft.CodeAnalysis.x.y.z.nupkg: 5771
Microsoft.Css.Parser.x.y.z.nupkg: 52964
Microsoft.Deployment.DotNet.Releases.x.y.z.nupkg: 79562
Microsoft.Diagnostics.NETCore.Client.x.y.z.nupkg: 63738
Microsoft.DiaSymReader.x.y.z.nupkg: 57811
Microsoft.DiaSymReader.x.y.z.nupkg: 301677
Microsoft.DotNet.ApiCompat.Task.x.y.z.nupkg: 1280207
Microsoft.DotNet.Arcade.Sdk.x.y.z.nupkg: 876107
Microsoft.DotNet.Build.Tasks.Archives.x.y.z.nupkg: 11400
Expand Down Expand Up @@ -161,7 +162,7 @@ Microsoft.Extensions.Identity.Core.x.y.z.nupkg: 96457
Microsoft.Extensions.Identity.Stores.x.y.z.nupkg: 32887
Microsoft.Extensions.Localization.Abstractions.x.y.z.nupkg: 17273
Microsoft.Extensions.Localization.x.y.z.nupkg: 24839
Microsoft.Extensions.Logging.Abstractions.x.y.z.nupkg: 238641
Microsoft.Extensions.Logging.Abstractions.x.y.z.nupkg: 159120
ellahathaway marked this conversation as resolved.
Show resolved Hide resolved
Microsoft.Extensions.Logging.Configuration.x.y.z.nupkg: 39074
Microsoft.Extensions.Logging.Console.x.y.z.nupkg: 83462
Microsoft.Extensions.Logging.Debug.x.y.z.nupkg: 31284
Expand All @@ -184,7 +185,7 @@ Microsoft.Internal.Runtime.AspNetCore.Transport.x.y.z.nupkg: 1193422
Microsoft.Internal.Runtime.DotNetApiDocs.Transport.x.y.z.nupkg: 1771155
Microsoft.Internal.Runtime.WindowsDesktop.Transport.x.y.z.nupkg: 1353080
Microsoft.JSInterop.x.y.z.nupkg: 41472
Microsoft.NET.Build.Containers.x.y.z.nupkg: 1558341
Microsoft.NET.Build.Containers.x.y.z.nupkg: 1044281
Microsoft.NET.Build.Extensions.x.y.z.nupkg: 853027
Microsoft.Net.Compilers.Toolset.x.y.z.nupkg: 8076123
Microsoft.NET.HostModel.x.y.z.nupkg: 54688
Expand Down Expand Up @@ -1003,7 +1004,7 @@ packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.InteropServices.
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.InteropServices.JavaScript.xml: 79204
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.InteropServices.RuntimeInformation.dll: 5120
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.InteropServices.xml: 691361
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.Intrinsics.dll: 289280
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.Intrinsics.dll: 367104
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.Intrinsics.xml: 2727813
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.Loader.dll: 9216
packs/Microsoft.NETCore.App.Ref/x.y.z/ref/netx.y/System.Runtime.Loader.xml: 22800
Expand Down Expand Up @@ -1877,6 +1878,8 @@ packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/mi
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/random.c: 3609
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/random.h: 721
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/strings.h: 948
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/time.c: 3058
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/time.h: 1049
ellahathaway marked this conversation as resolved.
Show resolved Hide resolved
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/types.h: 656
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/unicodedata.c: 84317
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/native/src/minipal/utf8.c: 69975
Expand Down Expand Up @@ -1909,7 +1912,7 @@ packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/sdk/System.Private.St
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/sdk/System.Private.TypeLoader.dll: 208384
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/sdk/System.Private.TypeLoader.pdb: 113324
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/sdk/System.Private.TypeLoader.xml: 124990
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/tools/ilc: 14069144
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/tools/ilc: 44610824
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/tools/libclrjit_universal_arm_x64.so: 38524184
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/tools/libclrjit_universal_arm64_x64.so: 46961296
packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/x.y.z/tools/libclrjit_unix_x64_x64.so: 46484080
Expand Down Expand Up @@ -2007,71 +2010,22 @@ sdk/x.y.z/.version: 114
sdk/x.y.z/AppHostTemplate/apphost: 767840
sdk/x.y.z/Containers/build/Microsoft.NET.Build.Containers.props: 1590
sdk/x.y.z/Containers/build/Microsoft.NET.Build.Containers.targets: 20007
sdk/x.y.z/Containers/tasks/netx.y/cs/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/cs/Microsoft.NET.Build.Containers.resources.dll: 16384
sdk/x.y.z/Containers/tasks/netx.y/cs/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/de/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/de/Microsoft.NET.Build.Containers.resources.dll: 17408
sdk/x.y.z/Containers/tasks/netx.y/de/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/es/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/es/Microsoft.NET.Build.Containers.resources.dll: 16896
sdk/x.y.z/Containers/tasks/netx.y/es/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/fr/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/fr/Microsoft.NET.Build.Containers.resources.dll: 17408
sdk/x.y.z/Containers/tasks/netx.y/fr/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/it/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/it/Microsoft.NET.Build.Containers.resources.dll: 17408
sdk/x.y.z/Containers/tasks/netx.y/it/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/ja/Microsoft.DotNet.Cli.Utils.resources.dll: 8192
sdk/x.y.z/Containers/tasks/netx.y/ja/Microsoft.NET.Build.Containers.resources.dll: 18944
sdk/x.y.z/Containers/tasks/netx.y/ja/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/ko/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/ko/Microsoft.NET.Build.Containers.resources.dll: 17408
sdk/x.y.z/Containers/tasks/netx.y/ko/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.DotNet.Cli.Utils.dll: 244224
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.Extensions.DependencyInjection.Abstractions.dll: 120320
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.Extensions.DependencyInjection.dll: 196608
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.Extensions.DependencyModel.dll: 168960
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.Extensions.Logging.Abstractions.dll: 124416
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.Extensions.Logging.dll: 79360
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.Extensions.Options.dll: 117760
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.Extensions.Primitives.dll: 64000
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.NET.Build.Containers.deps.json: 37253
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.NET.Build.Containers.deps.json: 26640
sdk/x.y.z/Containers/tasks/netx.y/Microsoft.NET.Build.Containers.dll: 535040
sdk/x.y.z/Containers/tasks/netx.y/MSBuild.dll: 800768
sdk/x.y.z/Containers/tasks/netx.y/Newtonsoft.Json.dll: 1843200
sdk/x.y.z/Containers/tasks/netx.y/NuGet.Common.dll: 365568
sdk/x.y.z/Containers/tasks/netx.y/NuGet.Configuration.dll: 596992
sdk/x.y.z/Containers/tasks/netx.y/NuGet.DependencyResolver.Core.dll: 299008
sdk/x.y.z/Containers/tasks/netx.y/NuGet.Frameworks.dll: 338944
sdk/x.y.z/Containers/tasks/netx.y/NuGet.LibraryModel.dll: 141824
sdk/x.y.z/Containers/tasks/netx.y/NuGet.Packaging.dll: 1693696
sdk/x.y.z/Containers/tasks/netx.y/NuGet.ProjectModel.dll: 785408
sdk/x.y.z/Containers/tasks/netx.y/NuGet.Protocol.dll: 2043904
sdk/x.y.z/Containers/tasks/netx.y/NuGet.Versioning.dll: 146944
sdk/x.y.z/Containers/tasks/netx.y/pl/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/pl/Microsoft.NET.Build.Containers.resources.dll: 17408
sdk/x.y.z/Containers/tasks/netx.y/pl/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/pt-BR/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/pt-BR/Microsoft.NET.Build.Containers.resources.dll: 16384
sdk/x.y.z/Containers/tasks/netx.y/pt-BR/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/ru/Microsoft.DotNet.Cli.Utils.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/ru/Microsoft.NET.Build.Containers.resources.dll: 20480
sdk/x.y.z/Containers/tasks/netx.y/ru/System.CommandLine.resources.dll: 9216
sdk/x.y.z/Containers/tasks/netx.y/runtimes/win/lib/netx.y/System.Security.Cryptography.Pkcs.dll: 741376
sdk/x.y.z/Containers/tasks/netx.y/System.CommandLine.dll: 337408
sdk/x.y.z/Containers/tasks/netx.y/System.Security.Cryptography.Pkcs.dll: 621056
sdk/x.y.z/Containers/tasks/netx.y/System.Security.Cryptography.ProtectedData.dll: 34304
sdk/x.y.z/Containers/tasks/netx.y/tr/Microsoft.DotNet.Cli.Utils.resources.dll: 7680
sdk/x.y.z/Containers/tasks/netx.y/tr/Microsoft.NET.Build.Containers.resources.dll: 16896
sdk/x.y.z/Containers/tasks/netx.y/tr/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/Valleysoft.DockerCredsProvider.dll: 39936
sdk/x.y.z/Containers/tasks/netx.y/zh-Hans/Microsoft.DotNet.Cli.Utils.resources.dll: 7168
sdk/x.y.z/Containers/tasks/netx.y/zh-Hans/Microsoft.NET.Build.Containers.resources.dll: 15872
sdk/x.y.z/Containers/tasks/netx.y/zh-Hans/System.CommandLine.resources.dll: 8704
sdk/x.y.z/Containers/tasks/netx.y/zh-Hant/Microsoft.DotNet.Cli.Utils.resources.dll: 7168
sdk/x.y.z/Containers/tasks/netx.y/zh-Hant/Microsoft.NET.Build.Containers.resources.dll: 15360
sdk/x.y.z/Containers/tasks/netx.y/zh-Hant/System.CommandLine.resources.dll: 8704
sdk/x.y.z/cs/dotnet.resources.dll: 189952
sdk/x.y.z/cs/Microsoft.Build.resources.dll: 102912
sdk/x.y.z/cs/Microsoft.Build.Tasks.Core.resources.dll: 155136
Expand Down Expand Up @@ -2204,7 +2158,6 @@ sdk/x.y.z/DotnetTools/dotnet-format/de/Microsoft.CodeAnalysis.Workspaces.resourc
sdk/x.y.z/DotnetTools/dotnet-format/de/System.CommandLine.resources.dll: 8704
sdk/x.y.z/DotnetTools/dotnet-format/dotnet-format.deps.json: 73859
sdk/x.y.z/DotnetTools/dotnet-format/dotnet-format.dll: 158720
sdk/x.y.z/DotnetTools/dotnet-format/dotnet-format.dll.config: 33595
sdk/x.y.z/DotnetTools/dotnet-format/dotnet-format.runtimeconfig.json: 413
sdk/x.y.z/DotnetTools/dotnet-format/es/dotnet-format.resources.dll: 19456
sdk/x.y.z/DotnetTools/dotnet-format/es/Microsoft.CodeAnalysis.CSharp.Features.resources.dll: 36864
Expand Down Expand Up @@ -2289,7 +2242,7 @@ sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.VisualBasic.Features.
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.VisualBasic.Workspaces.dll: 781824
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.Workspaces.dll: 3880960
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.CodeAnalysis.Workspaces.MSBuild.dll: 101376
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.DiaSymReader.dll: 76800
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.DiaSymReader.dll: 294400
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.Extensions.DependencyInjection.Abstractions.dll: 53760
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.Extensions.DependencyInjection.dll: 81920
sdk/x.y.z/DotnetTools/dotnet-format/Microsoft.Extensions.FileSystemGlobbing.dll: 35328
Expand Down Expand Up @@ -2473,7 +2426,6 @@ sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/de/Microsoft.CodeAnaly
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/de/System.CommandLine.resources.dll: 8704
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/dotnet-watch.deps.json: 54368
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/dotnet-watch.dll: 187392
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/dotnet-watch.dll.config: 33273
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/dotnet-watch.runtimeconfig.json: 511
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/DotNetWatch.targets: 4381
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/DotNetWatchTasks.dll: 12288
Expand Down Expand Up @@ -2528,7 +2480,7 @@ sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Microsoft.CodeAnalysis
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Microsoft.CodeAnalysis.Scripting.dll: 127488
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Microsoft.CodeAnalysis.Workspaces.dll: 3880960
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Microsoft.CodeAnalysis.Workspaces.MSBuild.dll: 101376
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Microsoft.DiaSymReader.dll: 76800
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Microsoft.DiaSymReader.dll: 294400
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/middleware/Microsoft.AspNetCore.Watch.BrowserRefresh.dll: 43008
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/Newtonsoft.Json.dll: 692736
sdk/x.y.z/DotnetTools/dotnet-watch/x.y.z/tools/netx.y/any/pl/dotnet-watch.resources.dll: 7168
Expand Down Expand Up @@ -3095,7 +3047,7 @@ sdk/x.y.z/NuGet.CommandLine.XPlat.dll: 701952
sdk/x.y.z/NuGet.CommandLine.XPlat.runtimeconfig.json: 347
sdk/x.y.z/NuGet.Commands.dll: 1510400
sdk/x.y.z/NuGet.Common.dll: 365568
sdk/x.y.z/NuGet.Configuration.dll: 596992
sdk/x.y.z/NuGet.Configuration.dll: 446976
sdk/x.y.z/NuGet.Credentials.dll: 172032
sdk/x.y.z/NuGet.DependencyResolver.Core.dll: 299008
sdk/x.y.z/NuGet.Frameworks.dll: 338944
Expand Down Expand Up @@ -3204,7 +3156,7 @@ sdk/x.y.z/Roslyn/bincore/ko/Microsoft.CodeAnalysis.resources.dll: 39424
sdk/x.y.z/Roslyn/bincore/ko/Microsoft.CodeAnalysis.VisualBasic.resources.dll: 311296
sdk/x.y.z/Roslyn/bincore/Microsoft.CodeAnalysis.CSharp.dll: 18190848
sdk/x.y.z/Roslyn/bincore/Microsoft.CodeAnalysis.dll: 8023552
sdk/x.y.z/Roslyn/bincore/Microsoft.CodeAnalysis.VisualBasic.dll: 13621248
sdk/x.y.z/Roslyn/bincore/Microsoft.CodeAnalysis.VisualBasic.dll: 4819456
sdk/x.y.z/Roslyn/bincore/pl/Microsoft.CodeAnalysis.CSharp.resources.dll: 445952
sdk/x.y.z/Roslyn/bincore/pl/Microsoft.CodeAnalysis.resources.dll: 39424
sdk/x.y.z/Roslyn/bincore/pl/Microsoft.CodeAnalysis.VisualBasic.resources.dll: 316416
Expand Down Expand Up @@ -4402,7 +4354,7 @@ sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.Build.Tasks.Pack.dll: 245248
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.Commands.dll: 1502720
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.Common.dll: 372736
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.Configuration.dll: 604160
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.Configuration.dll: 451584
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.Credentials.dll: 178688
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.DependencyResolver.Core.dll: 307200
sdk/x.y.z/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/NuGet.Frameworks.dll: 345088
Expand Down
8 changes: 8 additions & 0 deletions ...test/Microsoft.DotNet.SourceBuild.SmokeTests/assets/SdkContentTests/MsftToSbSdkFiles.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ index ------------
./packs/Microsoft.NETCore.App.Ref/
./packs/Microsoft.NETCore.App.Ref/x.y.z/
./packs/Microsoft.NETCore.App.Ref/x.y.z/analyzers/
@@ ------------ @@
./sdk-manifests/
./sdk-manifests/x.y.z/
./sdk-manifests/x.y.z/
-./sdk-manifests/x.y.z/
Copy link
Member

@ellahathaway ellahathaway Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The microsoft sdk has the following content in sdk-manifests/:

  • 8.0.100/
  • 9.0.100-preview.1/
  • 9.0.100-preview7/

The source-build sdk has the following content in sdk-manifests/:

  • 8.0.100/
  • 9.0.100-preview.7/

@MiYanni - Do you know if this is expected? Is the microsoft sdk supposed to have the preview 1 manifests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't actually know the composition of the SDK. @marcpopMSFT Does that look like it makes sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from here and is used in BundledManifests.targets.

This should definitely get updated to the latest, i.e. https://www.nuget.org/packages/Microsoft.NET.Sdk.Maui.Manifest-9.0.100-preview.5/9.0.0-preview.5.24307.10#readme-body-tab

The last time this was done was in dotnet/installer#18693.

@jonathanpeppers

Copy link
Member

@jonathanpeppers jonathanpeppers Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These always lag behind 1 release, as we want publicly listed packages. There is kind of a circular dependency here, .NET SDK -> MAUI -> .NET SDK. So, when .NET 9 GAs, we'll probably have .NET 9 RC 2 manifests in here.

We could update it now, though: it's been a while.

Copy link
Member

@ViktorHofer ViktorHofer Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we currently lagging 5 preview releases behind? I assume there is no automated process in place that makes sure those get updated? And what's the customer impact here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of any customer impact. I suppose you wouldn't get the latest workloads if you used the --skip-manifest-update switch.

To automate this, we might be able to use the same Maestro subscription that this repo will be using:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellahathaway if the source-build SDK doesn't contain maui workloads, then the missing 9.0.100-preview.1/ folder is expected and should be ignored. Note as discussed above, the folder name will change whenever the workload manifests for maui are updated.

@jonathanpeppers can you please file an issue in dotnet/sdk? We should probably also get the manifest updated from P1 to P5.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the source-build SDK doesn't contain maui workloads, then the missing 9.0.100-preview.1/ folder is expected and should be ignored. Note as discussed above, the folder name will change whenever the workload manifests for maui are updated.

Sounds good. I think the best course of action here is to add this diff to the baseline. I'll update this PR accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanpeppers can you please file an issue in dotnet/sdk? We should probably also get the manifest updated from P1 to P5.

I just opened a PR with the builds that shipped yesterday:

./sdk-manifests/x.y.z/microsoft.net.sdk.aspire/
./sdk-manifests/x.y.z/microsoft.net.sdk.aspire/x.y.z/
./sdk-manifests/x.y.z/microsoft.net.sdk.aspire/x.y.z/WorkloadManifest.Aspire.targets
@@ ------------ @@
./sdk/x.y.z/Microsoft.Build.NuGetSdkResolver.dll
./sdk/x.y.z/Microsoft.Build.Tasks.Core.dll
Expand Down
3 changes: 1 addition & 2 deletions .../Microsoft.DotNet.SourceBuild.SmokeTests/assets/SdkContentTests/SdkFileDiffExclusions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@
./sdk/x.y.z/*/Microsoft.VisualStudio.TestPlatform.Extensions.Trx.TestLogger.resources.dll|sb

# Needed for source-built NativeAOT with the source-built SDK
./library-packs/Microsoft.DotNet.ILCompiler.x.y.z.nupkg|sb
./library-packs/Microsoft.NET.ILLink.Tasks.x.y.z.nupkg|sb
./library-packs/|sb
./packs/runtime.banana-rid.Microsoft.DotNet.ILCompiler/|sb

# Runtime components in roslyn layout - https://github.com/dotnet/source-build/issues/4016
Expand Down