Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0.4xx] Update dependencies from dotnet/arcade #44065

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 4a4c595b-2701-4bcd-1cbb-08dc5a6a3fdf
  • Build: 20241008.1
  • Date Produced: October 8, 2024 6:38:56 PM UTC
  • Commit: e5b13e054339e41d422212a0ecaf24fec20cb5a1
  • Branch: refs/heads/release/8.0
  • Updates to .NET SDKs:
    • Updates tools.dotnet to 8.0.110

…008.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24504.2 -> To Version 8.0.0-beta.24508.1
@nagilson
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nagilson nagilson added the Area-Containers Related to dotnet SDK containers functionality label Oct 10, 2024
@marcpopMSFT marcpopMSFT removed the Area-Containers Related to dotnet SDK containers functionality label Oct 10, 2024
@marcpopMSFT
Copy link
Member

@manodasanW the three arcade updates are all failing with the same winrt error:
C:\h\w\A55308D3\t\dotnetSdkTests\5ektzu53.1av\ManagedWinRTC---79256FB9\ManagedWinRTComponent\obj\Debug\net8.0-windows10.0.19041.0\WinRT.SourceGenerator\Generator.SourceGenerator\ManagedWinRTComponent.cs(24,27): error CS0260: Missing partial modifier on declaration of type 'Coord'; another partial declaration of this type exists [C:\h\w\A55308D3\t\dotnetSdkTests\5ektzu53.1av\ManagedWinRTC--

These all update the SDK to the October release. Suggestions?

@manodasanW
Copy link
Contributor

manodasanW commented Oct 10, 2024

@marcpopMSFT This error should be fixed in my upcoming package version. The issue arose from an older version of CsWinRT being used with the new Windows SDK projection. To unblock, we can if we want update the CsWinRT version here to the latest as it is here in main.

@marcpopMSFT
Copy link
Member

@manodasanW your upcoming package version is a new windows sdk ref pack update? That won't help in the SDK repo since we use a shipped build of installer, correct? So we should make the change you suggest to get unblocked as otherwise, this won't get fixed until after your change goes into installer, we ship, and then we update arcade (so like a month)

@manodasanW
Copy link
Contributor

@manodasanW your upcoming package version is a new windows sdk ref pack update? That won't help in the SDK repo since we use a shipped build of installer, correct? So we should make the change you suggest to get unblocked as otherwise, this won't get fixed until after your change goes into installer, we ship, and then we update arcade (so like a month)

That makes sense to update the CsWinRT version then. Do you want me to go ahead and create a PR for it?

@manodasanW
Copy link
Contributor

@marcpopMSFT or would the PR be against the branch for this PR? Is this the PR updating the SDK version?

@marcpopMSFT
Copy link
Member

we should probably just do it in these three PRs if it's just a simple as updating that one version number. If you want to go ahead, please do.

@marcpopMSFT
Copy link
Member

Feel free to modify the darc branches directly for this PR, #44062, and #44061

@v-wuzhai v-wuzhai merged commit e453ac0 into release/8.0.4xx Oct 11, 2024
20 of 21 checks passed
@v-wuzhai v-wuzhai deleted the darc-release/8.0.4xx-16bc23e6-327c-4d59-8980-76fd1b66e7b4 branch October 11, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants