-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sln-list: Support for slnx #44537
sln-list: Support for slnx #44537
Conversation
@baronfel this looks good? |
This broke in internal CI: https://dev.azure.com/dnceng/internal/_build/results?buildId=2575716&view=results (internal link). It looks like it got merged w/o syncing in the changes from #43015 that were merged before this one. They don't work together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late to review but this looks great! I may have tweaked the wording a little bit on the command strings, but that is a nit; I dont think its worth doing that now. Love the use of the Range Operator :)
Contributes to #40913
This adds
dotnet sln list
support for .slnx filesThis also adds reusable logic to
SlnCommandParser
to be reused by other sln commands moving forward.