Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sln-list: Support for slnx #44537

Merged
merged 12 commits into from
Nov 5, 2024
Merged

sln-list: Support for slnx #44537

merged 12 commits into from
Nov 5, 2024

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Oct 30, 2024

Contributes to #40913

The dotnet CLI should support the new slnx format for building and in the existing solution management commands. It should also help interested users migrate to the new format.

This adds dotnet sln list support for .slnx files

image


This also adds reusable logic to SlnCommandParser to be reused by other sln commands moving forward.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CLI untriaged Request triage from a team member labels Oct 30, 2024
@edvilme edvilme changed the title [IMP] sln-list: Support for slnx (WIP) sln-list: Support for slnx (WIP) Oct 30, 2024
@edvilme edvilme marked this pull request as ready for review October 30, 2024 19:25
@edvilme edvilme requested a review from a team October 30, 2024 19:26
@edvilme edvilme changed the title sln-list: Support for slnx (WIP) sln-list: Support for slnx Oct 30, 2024
@kasperk81
Copy link
Contributor

@baronfel this looks good?

@edvilme edvilme requested a review from baronfel November 4, 2024 19:54
@edvilme edvilme merged commit bd5b082 into dotnet:main Nov 5, 2024
37 checks passed
@mthalman
Copy link
Member

mthalman commented Nov 5, 2024

This broke in internal CI: https://dev.azure.com/dnceng/internal/_build/results?buildId=2575716&view=results (internal link). It looks like it got merged w/o syncing in the changes from #43015 that were merged before this one. They don't work together.

@kasperk81
Copy link
Contributor

#44661

Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to review but this looks great! I may have tweaked the wording a little bit on the command strings, but that is a nit; I dont think its worth doing that now. Love the use of the Range Operator :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants