Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include net7.0 TFM for MSBuildLocator #207

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

mthalman
Copy link
Member

@mthalman mthalman commented Sep 11, 2023

The dependency flow of source-build-externals to roslyn is failing due to #204. See error info at dotnet/roslyn#69870 (comment). This is because roslyn builds with both net8.0 and net7.0 in source-build CI.

This is fixed by updating the target frameworks to include net7.0.

@mthalman
Copy link
Member Author

Getting a prebuilt because it's trying to use the latest 7.0 targeting pack:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23451.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NETCore.App.Ref.7.0.9

@mthalman mthalman enabled auto-merge (squash) September 11, 2023 21:32
@mthalman mthalman merged commit 5a3e627 into dotnet:main Sep 12, 2023
2 checks passed
@mthalman mthalman deleted the msbuildlocator branch September 12, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants