Finish noImplicitAny

src/observers/BaseChannelObserver.ts

@@ -4,7 +4,6 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as vscode from '../vscodeAdapter';
-import { ViewColumn } from "../vscodeAdapter";
 import { BaseEvent } from '../omnisharp/loggingEvents';
 
 export abstract class BaseChannelObserver {
@@ -14,13 +13,8 @@ export abstract class BaseChannelObserver {
 
     abstract post: (event: BaseEvent) => void;
 
-    public showChannel(preserveFocusOrColumn?: boolean | ViewColumn, preserveFocus?: boolean) {
-        if (typeof(preserveFocusOrColumn) === "boolean") {
-            this.channel.show(preserveFocusOrColumn as boolean);
-        }
-        else {
-            this.channel.show(preserveFocusOrColumn as ViewColumn, preserveFocus);
-        }
+    public showChannel(preserveFocusOrColumn?: boolean) {
+        this.channel.show(preserveFocusOrColumn as boolean);
     }
 
     public clearChannel() {

src/observers/OmnisharpChannelObserver.ts

@@ -3,7 +3,6 @@
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
 
-import * as vscode from '../vscodeAdapter';
 import { BaseChannelObserver } from "./BaseChannelObserver";
 import { BaseEvent, CommandShowOutput, OmnisharpFailure } from '../omnisharp/loggingEvents';
 
@@ -12,7 +11,7 @@ export class OmnisharpChannelObserver extends BaseChannelObserver {
     public post = (event: BaseEvent) => {
         switch (event.constructor.name) {
             case CommandShowOutput.name:
-                this.showChannel(vscode.ViewColumn.Three);
+                this.showChannel();
                 break;
             case OmnisharpFailure.name:
                 this.showChannel();

src/vscodeAdapter.ts

@@ -37,16 +37,6 @@ export interface OutputChannel {
      */
     show(preserveFocus?: boolean): void;
 
-    /**
-     * ~~Reveal this channel in the UI.~~
-     *
-     * @deprecated Use the overload with just one parameter (`show(preserveFocus?: boolean): void`).
-     *
-     * @param column This argument is **deprecated** and will be ignored.
-     * @param preserveFocus When `true` the channel will not take focus.
-     */
-    show(column?: ViewColumn, preserveFocus?: boolean): void;
-
     /**
      * Hide this channel from the UI.
      */

tasks/offlinePackagingTasks.ts

@@ -21,6 +21,7 @@ import { getPackageJSON } from '../tasks/packageJson';
 import { Logger } from '../src/logger';
 import { PackageManager } from '../src/packages';
 import { PlatformInformation } from '../src/platform';
+import { Result } from 'async-child-process';
 
 gulp.task('vsix:offline:package', () => {
     del.sync(vscodeignorePath);
@@ -57,7 +58,7 @@ function doPackageOffline() {
         new PlatformInformation('linux', 'x86_64')
     ];
 
-    let promise = Promise.resolve();
+    let promise: Promise<Result> = Promise.resolve<Result>(null);
 
     packages.forEach(platformInfo => {
         promise = promise

tasks/onlinePackagingTasks.ts

@@ -37,11 +37,6 @@ gulp.task('vsix:release:package', (onError) => {
 
     fs.copyFileSync(onlineVscodeignorePath, vscodeignorePath);
 
-    let onDone = (reason) => {
-
-        onError(reason);
-    };
-
     return spawnNode([vscePath, 'package'])
         .then(() => {
             del(vscodeignorePath);

test/unitTests/logging/OmnisharpChannelObserver.test.ts

@@ -22,16 +22,4 @@ suite("OmnisharpChannelObserver", () => {
         observer.post(event);
         expect(hasShown).to.be.true;
     });
-
-    test('CommandShowOutput: Shows the channel', () => {
-        let event = new CommandShowOutput();
-        let testColumn: vscode.ViewColumn;
-        let observer = new OmnisharpChannelObserver({
-            ...getNullChannel(),
-            show: (column?: ViewColumn, preserveFocus?: boolean) => { testColumn = column;}
-        });
-
-        observer.post(event);
-        expect(testColumn).to.be.equal(vscode.ViewColumn.Three);
-    });
 });

typings/async-child-process.d.ts

@@ -0,0 +1,11 @@
+declare module 'async-child-process' {
+
+    import { ChildProcess } from "child_process";
+
+    export function join(childProcess: ChildProcess): Promise<Result>;
+
+    export interface Result {
+        code: string;
+        signal: string;
+    }
+}