Consume the completion trigger character API #1776
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also take a dependency on version 1.17 where it was added
rchande
commented
Oct 4, 2017
package.json
Outdated
| @@ -1360,7 +1358,16 @@ | |||
| "request": "attach", | |||
| "processId": "${command:pickProcess}" | |||
| } | |||
| ] | |||
| ], | |||
| "windows": { | |||
There was a problem hiding this comment.
I'm not sure why these got added. Presumably they can be removed?
There was a problem hiding this comment.
Remove these. Otherwise, they'll break the debugger.
package.json
Outdated
| @@ -1360,7 +1358,16 @@ | |||
| "request": "attach", | |||
| "processId": "${command:pickProcess}" | |||
| } | |||
| ] | |||
| ], | |||
| "windows": { | |||
There was a problem hiding this comment.
Remove these. Otherwise, they'll break the debugger.
|
@DustinCampbell Right--I was going to ask you if you if we had a different branch that tracked the latest insiders build (or something). |
|
Also cc @piotrpMSFT and @jonsequitur in case they're interested. |
|
We don't have a different branch as we haven't been on the bleeding edge with VS Code APIs yet. |
DustinCampbell
approved these changes
Oct 27, 2017
|
Fixes #146 |
|
Thanks @DustinCampbell |
|
For some reason, CI is hung for this PR. So, I went ahead and built and ran tests on my machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also take a dependency on version 1.17 where it was added and request to trigger completion on space.