Revisit launch on Mono #1789
Merged
Revisit launch on Mono #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregg-miskelly
approved these changes
Oct 16, 2017
|
One nice benefit of this change is that OmniSharp will run faster on OSX when running on a globally-installed Mono because of the AOT images that Mono installs for core framework assemblies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes OmniSharp to be with the 'mono' on the path, if it is available and at least version 5.2.0. If 'mono' can't be found, we fall back to our local Mono.
In addition, I fixed a few bugs I noticed while testing:
--assembly-loader=strictargument is passed to Mono in the proper order. Since it's an argument to Mono, it needs to appear before any OmniSharp arguments.