Make hover integration test pass #2050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshita31
changed the title
|
@akshita31 The solution we discussed was to just always include the "hover" file in the test solution. However, if this works, I'm happy to take it :). I restarted your PR build to see if it's flaky. |
rchande
reviewed
Feb 17, 2018
|
|
||
| await vscode.workspace.openTextDocument(fileUri); | ||
|
|
||
| await vscode.commands.executeCommand("vscode.open", fileUri); |
There was a problem hiding this comment.
Why did you move away from the openTextDocument helper that you switched to?
There was a problem hiding this comment.
No specific reason. I just thought it would maintain consistency with the codeActionRename test. Is openTextDocument a better way ?
|
This approach doesn't work. Closing this in favor of #2058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hover integration test is failing because of a possible race condition between the omnisharp process and the vscode process to access the file that has been added. Hence, if we restart the server before we ask vscode to open it, omnisharp will have read the file and no problem should occur.
PS: I am not sure whether this is the best approach to solve this, because we will have to restart the server whenever we add a file for testing.