Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the config looks functional return it, otherwise force VSCode to open config file #2558

Merged
merged 4 commits into from
Oct 2, 2018
Merged

If the config looks functional return it, otherwise force VSCode to open config file #2558

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ed56fd
If the config looks functional return it, otherwise force VSCode to o…
isidorn Sep 27, 2018
cdb5b7c
Merge branch 'master' into isidorn/debugConfig
gregg-miskelly Oct 2, 2018
db8ccd4
Merge branch 'master' into isidorn/debugConfig
gregg-miskelly Oct 2, 2018
fec2fad
Merge branch 'master' into isidorn/debugConfig
gregg-miskelly Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/configurationProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ export class CSharpConfigurationProvider implements vscode.DebugConfigurationPro
config = this.parseEnvFile(config.envFile.replace(/\${workspaceFolder}/g, folder.uri.fsPath), config);
}

// vsdbg will error check the debug configuration fields
return config;
}
// If the config looks functional return it, otherwise force VSCode to open a configuration file https://github.com/Microsoft/vscode/issues/54213
return config && config.type ? config : null;
}

private static async showFileWarningAsync(message: string, fileName: string) {
const openItem: MessageItem = { title: 'Open envFile' };
Expand Down