Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop activating the C# extension on all debugging #2698

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Stop activating the C# extension on all debugging #2698

merged 1 commit into from
Nov 21, 2018

Conversation

gregg-miskelly
Copy link
Contributor

@gregg-miskelly gregg-miskelly commented Nov 21, 2018 •
edited
Loading

This updates the C# extension to activate only on debugging operations that involve C# scenarios.

Testing:

  • Verified that C# launch.json templates are correctly shown and work when attempt to start debugging from an empty folder
  • Verified that we can start debugging with a work space folder that contains no C# files

This fixes #2658

@gregg-miskelly
Stop activating the C# extension on all debugging
3e7eecb 
This updates the C# extension to activate only on debugging operations that involve C# scenarios.
@gregg-miskelly gregg-miskelly merged commit 678ea5b into dotnet:master Nov 21, 2018
@gregg-miskelly gregg-miskelly deleted the DebugActivationEvents branch November 21, 2018 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckries chuckries chuckries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using onDebug activationEvent
2 participants
@gregg-miskelly @chuckries