Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify excluded code #3789

Merged
merged 1 commit into from
May 16, 2020
Merged

Conversation

JoeRobich
Copy link
Member

Resolves #3788

image

Requires a color to be specified for the "support.other.excluded" scope. Recommend using the following tweaks:

VS2019 theme tweaks:
    "editor.tokenColorCustomizations": {
        "[Default Dark+]": {
            "textMateRules": [
                {
                    "scope": "support.other.excluded",
                    "settings": {
                        "foreground": "#808080"
                    }
                },
                {
                    "scope": "keyword.preprocessor",
                    "settings": {
                        "foreground": "#808080"
                    }
                },
                {
                    "scope": "punctuation",
                    "settings": {
                        "foreground": "#D4D4D4"
                    }
                },
                {
                    "scope": "entity.name.namespace",
                    "settings": {
                        "foreground": "#D4D4D4"
                    }
                },
                {
                    "scope": "entity.name.variable.field",
                    "settings": {
                        "foreground": "#D4D4D4"
                    }
                },
                {
                    "scope": "variable.other.property",
                    "settings": {
                        "foreground": "#D4D4D4"
                    }
                },
                {
                    "scope": "variable.other.constant",
                    "settings": {
                        "foreground": "#D4D4D4",
                    }
                },
                {
                    "scope": "variable.other.enummember",
                    "settings": {
                        "foreground": "#D4D4D4"
                    }
                },
                {
                    "scope": "entity.name.type.interface",
                    "settings": {
                        "foreground": "#b8d7a3"
                    }
                },
                {
                    "scope": "entity.name.type.enum",
                    "settings": {
                        "foreground": "#b8d7a3"
                    }
                },
                {
                    "scope": "entity.name.type.parameter",
                    "settings": {
                        "foreground": "#b8d7a3"
                    }
                },
                {
                    "scope": "entity.name.type.struct",
                    "settings": {
                        "foreground": "#86C691",
                    }
                },
                {
                    "scope": "entity.name.function.extension",
                    "settings": {
                        "foreground": "#DCDCAA",
                    }
                },
                {
                    "scope": "comment.documentation",
                    "settings": {
                        "foreground": "#608B4E",
                    }
                },
                {
                    "scope": "comment.documentation.attribute",
                    "settings": {
                        "foreground": "#C8C8C8",
                    }
                },
                {
                    "scope": "comment.documentation.cdata",
                    "settings": {
                        "foreground": "#E9D585",
                    }
                },
                {
                    "scope": "comment.documentation.delimiter",
                    "settings": {
                        "foreground": "#808080",
                    }
                },
                {
                    "scope": "comment.documentation.name",
                    "settings": {
                        "foreground": "#569CD6",
                    }
                },
                {
                    "scope": "comment.regex",
                    "settings": {
                        "foreground": "#57A64A",
                    }
                },
                {
                    "scope": "constant.character.character-class.regexp",
                    "settings": {
                        "foreground": "#2EABFE",
                    }
                },
                {
                    "scope": "keyword.control.anchor.regexp",
                    "settings": {
                        "foreground": "#F979AE",
                    }
                },
                {
                    "scope": "keyword.operator.quantifier.regexp",
                    "settings": {
                        "foreground": "#F979AE",
                    }
                },
                {
                    "scope": "punctuation.definition.group.regexp",
                    "settings": {
                        "foreground": "#05C3BA",
                    }
                },
                {
                    "scope": "keyword.operator.or.regexp",
                    "settings": {
                        "foreground": "#05C3BA",
                    }
                },
                {
                    "scope": "string.regexp",
                    "settings": {
                        "foreground": "#D69D85",
                    }
                },
                {
                    "scope": "constant.character.escape.regexp",
                    "settings": {
                        "foreground": "#D69D85",
                    }
                },
                {
                    "scope": "constant.other.escape.regexp",
                    "settings": {
                        "foreground": "#FFD68F",
                    }
                },
            ]
        },
        "[Default Light+]": {
            "textMateRules": [
                {
                    "scope": "support.other.excluded",
                    "settings": {
                        "foreground": "#808080"
                    }
                },
                {
                    "scope": "keyword.preprocessor",
                    "settings": {
                        "foreground": "#808080"
                    }
                },
                {
                    "scope": "punctuation",
                    "settings": {
                        "foreground": "#222222"
                    }
                },
                {
                    "scope": "entity.name.namespace",
                    "settings": {
                        "foreground": "#222222"
                    }
                },
                {
                    "scope": "entity.name.variable.field",
                    "settings": {
                        "foreground": "#222222"
                    }
                },
                {
                    "scope": "variable.other.property",
                    "settings": {
                        "foreground": "#222222"
                    }
                },
                {
                    "scope": "variable.other.constant",
                    "settings": {
                        "foreground": "#222222",
                    }
                },
                {
                    "scope": "variable.other.enummember",
                    "settings": {
                        "foreground": "#222222"
                    }
                },
                {
                    "scope": "entity.name.type.interface",
                    "settings": {
                        "foreground": "#267f99"
                    }
                },
                {
                    "scope": "entity.name.type.enum",
                    "settings": {
                        "foreground": "#267f99"
                    }
                },
                {
                    "scope": "entity.name.type.parameter",
                    "settings": {
                        "foreground": "#267f99"
                    }
                },
                {
                    "scope": "entity.name.type.struct",
                    "settings": {
                        "foreground": "#267f99",
                    }
                },
                {
                    "scope": "entity.name.function.extension",
                    "settings": {
                        "foreground": "#795E26",
                    }
                },
                {
                    "scope": "comment.documentation",
                    "settings": {
                        "foreground": "#008000",
                    }
                },
                {
                    "scope": "comment.documentation.attribute",
                    "settings": {
                        "foreground": "#282828",
                    }
                },
                {
                    "scope": "comment.documentation.cdata",
                    "settings": {
                        "foreground": "#808080",
                    }
                },
                {
                    "scope": "comment.documentation.delimiter",
                    "settings": {
                        "foreground": "#808080",
                    }
                },
                {
                    "scope": "comment.documentation.name",
                    "settings": {
                        "foreground": "#808080",
                    }
                }
            ]
        }
    },

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #3789 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3789   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files          59       59           
  Lines        1805     1805           
  Branches      208      208           
=======================================
  Hits         1569     1569           
  Misses        181      181           
  Partials       55       55           
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 86.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b64b62...3a07cbc. Read the comment docs.

@JoeRobich JoeRobich merged commit 1fe37dc into dotnet:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic highlighter doesn't gray out disabled regions
2 participants