Discover and execute (both run and debug) xunit test in VS Code #382

troydai · 2016-05-26T22:38:43Z

Demo

it's a gif, may take time to load

Brief

The change relies on a change in OmniSharp which supports test discovery and execution.

It also relies on startDebug command from VS Code to start debugger. For earlier version of VS Code, the debug test link won't show up on Code Lens.

Open question

How and where to show test result. Currently, the test result is shown in message box. Could there be a better way to organize and show test results?

gregg-miskelly · 2016-05-27T01:26:58Z

Woohoo! Question: Is this stuff about ready to ship? Or do you need to more work first? The stuff currently in 'dev' is almost ready to ship. So if this will not be ready within the next week, I think we need another branch.

troydai · 2016-05-27T03:28:25Z

@gregg-miskelly besides the open question the PR surely needs more testing. Baring a major issue the main structure is in place. If new features are provisioned during the code review, they can be added incrementally afterwards.

There are small changes I'll make additionally. Specifically:

Add a test panel in which test output are printed.
More information for test result.

The only open question is how we report the test result. The current behavior is to report in the message box which is not idea.

I'm confident it is good enough for next week's ship. I'm not chasing a timeline here, but base on the exciting feedback I got from my demo, I really hope this can get to users early. Of course I'd like to have C# extension crew to take a look at the changes and give me more feedback.

gregg-miskelly · 2016-05-27T15:54:46Z

src/features/dotnetTest.ts

+
+export function registerDotNetTestRunCommand(server: OmnisharpServer): vscode.Disposable {
+    return vscode.commands.registerCommand(
+        'dotnet.test.run',


Should these be listed in our package.json?

gregg-miskelly · 2016-05-27T16:17:01Z

troydai · 2016-05-27T16:38:17Z

Thanks, I'll adjust the test message a bit and address the comments. Afterward this PR should be done. But I won't merge until the corresponding PR on OmniSharp side is merged (that shouldn't be blocked for too long).

troydai · 2016-05-28T01:50:28Z

@gregg-miskelly @DustinCampbell
I make some changes to address comments and changes in OmniSharp. Changes on the server side has been merged. A release is drafted: https://github.com/OmniSharp/omnisharp-roslyn/releases/tag/1.9-beta2.

gregg-miskelly · 2016-05-28T05:55:05Z

@troydai LGTM. Dustin would need to comment on how to put the OmniSharp release on Azure blob storage, and if we want to do that now, or wait till we get closer to release.

DustinCampbell · 2016-05-31T16:38:09Z

src/features/commands.ts

-	return vscode.Disposable.from(d1, d2, d3, d4, d5);
+
+    return vscode.Disposable.from(d1, d2, d3, d4, d5,
+        dotnetTest.registerDotNetTestRunCommand(server),


Maybe follow the same pattern as the rest of the disposables?

DustinCampbell · 2016-05-31T16:44:14Z

LGTM

I'll work on updating to a newer release of OmniSharp. It looks like 1.9-beta4 has all of the releases we'll need.

troydai · 2016-05-31T17:01:53Z

All set. Can somebody merge this for me?

DustinCampbell · 2016-05-31T19:20:28Z

src/protocol.ts

+
+// dotnet-test endpoints
+
+export interface GetTestStartInfoRequest {


Hey @troydai -- are these new v2 endpoints? If so, could you include them in the V2 namespace above?

right. i'll send another PR to fix this.

kerryjiang · 2016-06-03T13:51:38Z

I am looking forward to use this new feature!
I am trying to debug test using Visual Studio Code, but no luck for now.
I tried to add a new node in launch.json, but haven't make it work.

gregg-miskelly · 2016-06-03T14:33:44Z

There is a release preview with this support:

Download the latest vsix from https://github.com/OmniSharp/omnisharp-vscode/releases
In VS Code, File->Open the vsix file (do NOT double click it, that will not work)
At the top of a test method, there will be a link to debug it. Click that.

kerryjiang · 2016-06-03T16:01:27Z

Thanks Greg, but after I installed the latest C# extension and then installed the debuger successfully, the omnisharp always show "starting" status.

There might be something wrong.

Thank you all the same!

DustinCampbell · 2016-06-03T16:34:42Z

@kerryjiang, if you select View->Toggle Output from the menu and change the selector to "OmniSharp Log" what do you see?

kerryjiang · 2016-06-03T16:42:40Z

@DustinCampbell

The last log always be downloading...

[INFO] Starting OmniSharp at '/Users/kerryjiang/WorkShop/NRack/master/src/NRack.Base'...
[INFO] Installing to /Users/kerryjiang/.vscode/extensions/ms-vscode.csharp-1.1.2/.omnisharp
[INFO] Attempting to download omnisharp-1.9-beta4-osx-x64-netcoreapp1.0.tar.gz...
[INFO] Downloading to /var/folders/n2/vkp2byyx5vgbvz1cqk_phmc40000gn/T/tmp-92895XQ1dhrwgkZx.tmp...

DustinCampbell · 2016-06-03T16:53:26Z

Are you behind a proxy? Have you configured it in VS Code?

kerryjiang · 2016-06-03T16:58:21Z

Not a proxy.
Probably is a network issue.

gregg-miskelly · 2016-06-04T01:11:20Z

@kerryjiang did this ever wind up working for you?

kerryjiang · 2016-06-04T01:41:33Z

@gregg-miskelly @DustinCampbell

Thanks guys, it works now.
My network was really slow last night.

BingyuLiu · 2016-06-09T00:19:44Z

@gregg-miskelly

@andschwa and I have VS Code insiders edition, 1.3.0-1465425900, with C# extension 1.1.5, on Ubuntu 14.04. We have a .NET Core xUnit test file opened, but we do not have the link to run the test in the debugger that we see here.

Is this simply a Windows only feature, or not available in .NET Core? We cannot currently find a way to attach to dotnet test, as it executes as a child process. Short of writing a shim, what can we do?

BingyuLiu · 2016-06-09T00:27:42Z

FWIW we don't have a "Toggle OmniSharp log", are we missing something simple?

DustinCampbell · 2016-06-09T02:16:17Z

@BingyuLiu, @andschwa: could you file an issue rather starting a conversation on PR that has already been merged?

troydai · 2016-06-09T05:59:09Z

@BingyuLiu please attack your test project while open the issue. It will be very helpful for us to investigate this issue. It is not Windows only feature.

troydai added 6 commits May 25, 2016 21:48

Add dotnet-test discovery and execution

b92e0b6

split arguments to prevent long argument issue

7193f18

test result feedback

fe2e7a4

move dotnet test logic to its own file

0302243

move code from codelens provider to dotnetTest

1efd3b4

disable debug trigger if startDebug command doesn't exist

60e9de7

dnfclas added the cla-already-signed label May 26, 2016

troydai mentioned this pull request May 27, 2016

Add capability to discover and run xunit test OmniSharp/omnisharp-roslyn#562

Merged

gregg-miskelly reviewed May 27, 2016
View reviewed changes

troydai added 3 commits May 27, 2016 11:43

Update endpoint names for test scenarios

ca485c8

Move isDebugEnable switch into OmniSharpServer

bc3222c

Add test output channel

5c9ee8e

DustinCampbell reviewed May 31, 2016
View reviewed changes

Address review comments

62b9fe2

DustinCampbell merged commit 969188d into dotnet:dev May 31, 2016

DustinCampbell reviewed May 31, 2016
View reviewed changes

DustinCampbell mentioned this pull request Jun 9, 2016

Add support for 'dotnet test' #311

Closed

gregg-miskelly mentioned this pull request Jun 15, 2016

I can't hit the break point in VS code #417

Closed

dustinmoris mentioned this pull request Apr 15, 2017

Debug xunit tests ionide/ionide-vscode-fsharp#408

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Discover and execute (both run and debug) xunit test in VS Code #382

Discover and execute (both run and debug) xunit test in VS Code #382

troydai commented May 26, 2016 •

edited

Loading

gregg-miskelly commented May 27, 2016

troydai commented May 27, 2016

gregg-miskelly May 27, 2016

gregg-miskelly commented May 27, 2016

troydai commented May 27, 2016

troydai commented May 28, 2016

gregg-miskelly commented May 28, 2016

DustinCampbell May 31, 2016

troydai May 31, 2016

DustinCampbell commented May 31, 2016

troydai commented May 31, 2016

DustinCampbell May 31, 2016

troydai May 31, 2016

kerryjiang commented Jun 3, 2016

gregg-miskelly commented Jun 3, 2016

kerryjiang commented Jun 3, 2016

DustinCampbell commented Jun 3, 2016

kerryjiang commented Jun 3, 2016 •

edited

Loading

DustinCampbell commented Jun 3, 2016

kerryjiang commented Jun 3, 2016

gregg-miskelly commented Jun 4, 2016

kerryjiang commented Jun 4, 2016

BingyuLiu commented Jun 9, 2016

BingyuLiu commented Jun 9, 2016

DustinCampbell commented Jun 9, 2016

troydai commented Jun 9, 2016


		// dotnet-test endpoints

		export interface GetTestStartInfoRequest {

Discover and execute (both run and debug) xunit test in VS Code #382

Discover and execute (both run and debug) xunit test in VS Code #382

Conversation

troydai commented May 26, 2016 • edited Loading

Demo

Brief

Open question

gregg-miskelly commented May 27, 2016

troydai commented May 27, 2016

gregg-miskelly May 27, 2016

Choose a reason for hiding this comment

gregg-miskelly commented May 27, 2016

troydai commented May 27, 2016

troydai commented May 28, 2016

gregg-miskelly commented May 28, 2016

DustinCampbell May 31, 2016

Choose a reason for hiding this comment

troydai May 31, 2016

Choose a reason for hiding this comment

DustinCampbell commented May 31, 2016

troydai commented May 31, 2016

DustinCampbell May 31, 2016

Choose a reason for hiding this comment

troydai May 31, 2016

Choose a reason for hiding this comment

kerryjiang commented Jun 3, 2016

gregg-miskelly commented Jun 3, 2016

kerryjiang commented Jun 3, 2016

DustinCampbell commented Jun 3, 2016

kerryjiang commented Jun 3, 2016 • edited Loading

DustinCampbell commented Jun 3, 2016

kerryjiang commented Jun 3, 2016

gregg-miskelly commented Jun 4, 2016

kerryjiang commented Jun 4, 2016

BingyuLiu commented Jun 9, 2016

BingyuLiu commented Jun 9, 2016

DustinCampbell commented Jun 9, 2016

troydai commented Jun 9, 2016

troydai commented May 26, 2016 •

edited

Loading

kerryjiang commented Jun 3, 2016 •

edited

Loading