New completion service #3986
Merged
New completion service #3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the roslyn backend for a better overall completion experience.
Codecov Report
@@ Coverage Diff @@
## master #3986 +/- ##
==========================================
+ Coverage 85.96% 85.99% +0.03%
==========================================
Files 60 60
Lines 1852 1856 +4
Branches 214 214
==========================================
+ Hits 1592 1596 +4
Misses 200 200
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I added a new test for override completion that should hopefully fail until the roslyn dependency is updated. If it doesn't fail, I'll be concerned... |
|
Finally, Waiting for merge and new release |
|
@JoeRobich this now has an option for import completion as well. |
JoeRobich
reviewed
Aug 20, 2020
Co-authored-by: Joey Robichaud <[email protected]>
|
thanks for adding the VS Code option for |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new completion service being added in OmniSharp/omnisharp-roslyn#1877. This enables things like override completion, as well as overall faster completion due to less filtering and preprocessing being done on the server side.
Fixes #1044.
Fixes #3687.