Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to organize imports during document formatting. #4302

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

JoeRobich
Copy link
Member

This flag was added to OmniSharp a while back but we never introduced a VS Code setting.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #4302 (151b11d) into master (b04c301) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4302      +/-   ##
==========================================
+ Coverage   85.99%   86.01%   +0.01%     
==========================================
  Files          60       60              
  Lines        1857     1859       +2     
  Branches      215      215              
==========================================
+ Hits         1597     1599       +2     
  Misses        200      200              
  Partials       60       60              
Flag Coverage Δ
integration 100.00% <ø> (ø)
unit 86.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/observers/OptionChangeObserver.ts 100.00% <ø> (ø)
src/omnisharp/options.ts 94.56% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04c301...151b11d. Read the comment docs.

Copy link
Contributor

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 👏

@JoeRobich JoeRobich merged commit 687fe0e into dotnet:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants