Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid white status bar items to ensure contrast #4385

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Avoid white status bar items to ensure contrast #4385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f6a191
Avoid white status bar items to ensure contrast
Tyriar Feb 7, 2021
c744034
Remove white status bar ref from test
Tyriar Feb 7, 2021
28f59d5
Fix arg order
Tyriar Feb 7, 2021
11ea57d
Merge branch 'master' into patch-1
JoeRobich Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/observers/OmnisharpStatusBarObserver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ import { EventType } from "../omnisharp/EventType";
export enum StatusBarColors {
Red = 'rgb(218,0,0)',
Green = 'rgb(0,218,0)',
Yellow = 'rgb(218,218,0)',
White = 'rgb(256,256,256)'
Yellow = 'rgb(218,218,0)'
}

export class OmnisharpStatusBarObserver extends BaseStatusBarItemObserver {
Expand All @@ -34,7 +33,7 @@ export class OmnisharpStatusBarObserver extends BaseStatusBarItemObserver {
this.ResetAndHideStatusBar();
break;
case EventType.OmnisharpServerOnStart:
this.SetAndShowStatusBar('$(flame)', 'o.showOutput', StatusBarColors.White, 'OmniSharp server is running');
this.SetAndShowStatusBar('$(flame)', 'o.showOutput', undefined, 'OmniSharp server is running');
break;
case EventType.DownloadStart:
this.SetAndShowStatusBar("$(cloud-download) Downloading packages", '', '', `Downloading package '${(<DownloadStart>event).packageDescription}...' `);
Expand Down
1 change: 0 additions & 1 deletion test/unitTests/logging/OmnisharpStatusBarObserver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ suite('OmnisharpStatusBarObserver', () => {
expect(statusBarItem.text).to.be.equal('$(flame)');
expect(statusBarItem.command).to.equal('o.showOutput');
expect(statusBarItem.tooltip).to.be.equal('OmniSharp server is running');
expect(statusBarItem.color).to.be.equal(StatusBarColors.White);
});

test('OnServerStop: Status bar is hidden and the attributes are set to undefined', () => {
Expand Down