Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merged PR 475885: Add support for F5 for csproj and sln" #5875

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Revert "Merged PR 475885: Add support for F5 for csproj and sln" #5875

merged 1 commit into from
Jun 28, 2023

Conversation

WardenGnaw
Copy link
Contributor

This reverts commit 173be18.

Fixes: #5860

@WardenGnaw WardenGnaw requested a review from a team as a code owner June 28, 2023 17:53
@arunchndr
Copy link
Member

Could we please add a note in the Known issues of the C# extension that highlights the workaround?

@WardenGnaw
Copy link
Contributor Author

Could we please add a note in the Known issues of the C# extension that highlights the workaround?

Is this pinning the issue or am I adding this in a markdown file?

@arunchndr
Copy link
Member

Is this pinning the issue or am I adding this in a markdown file?

You could add your long terms plans to an issue and add that to the list under #5736

@WardenGnaw WardenGnaw merged commit 03c84c8 into main Jun 28, 2023
@WardenGnaw WardenGnaw deleted the dev/waan/revertF5csprojAndSln branch June 28, 2023 18:40
arunchndr added a commit that referenced this pull request Jul 10, 2023
@arunchndr @dibarbet
@JoeRobich @leslierichardson95 @mavasani @WardenGnaw @davidwengier @ryzngard @mikadumont
Main to prerelease 0710 (#5909)
55ec0fb 
* Increase release CI timeout

* Add CI for release branch

* Add eslint and fix warnings

* Implement report issue command for prerelease extension

* Update O# Roslyn and prepare for release

* Switch to non-deprecated action for asset upload

* Upload all VSIX in one step

* Update .github/workflows/release-ci.yml

Co-authored-by: Joey Robichaud <[email protected]>

* Update release-ci.yml

* review feedback

* use vscode-uri

* Add write permissions to job

* Fix options schema

* Explicitly throw if runtimeId is missing

* Use real looking runtimeId in fake

* Use issue reporter command

* Add server path as an option to allow Razor to re-use the runtime resolver

* Fix brace

* More lint

* Update README.md to notify user about .NET Runtime Tool

* Enable full solution background analysis

- Adds 2 new background analysis scope options: one for compiler diagnostics and one for analyzer diagnostics
- Both the options allow the same set of values as in VS: Open documents, Entire solution, Current document and None (disabled). Currently, `Current document` option is not yet supported in LSP as we do not have a way to know which is the current active document in LSP server.
- Builds on top of dotnet/roslyn#68799
- Needs couple more Roslyn side changes as a follow-up: dotnet/roslyn#68797 and dotnet/roslyn#68798

* Remove the un-supported `Current Document` option

* File renames

* Remove TSLint and configure eslint

* Enable remaining rules from tslint and remove

* Run prettier automatic fixer

* address a couple remaining eslint errors

* Remove incorrectly cased folders

* Remove duplicate license header

* Fix options schema after package.json changes

* Fix chai test assertion library usages

* Avoid using 'solution crawler' terminology in the VSCode option name

* Address feedback and fix test

* Revert unintentional changes from merge

* Some more reverts

* Address feedback and also fix linting issues

* Revert "Merged PR 475885: Add support for F5 for csproj and sln" (#5875)

This reverts commit 173be18.

* Update README.md to make runtime extension note numbered

* Bump Razor to 7.0.0-preview.23328.2

* Allow updatePackageDependencies to work with Razor (well, with prerelease packages)

* Add task for updating Razor deps

* Move to newer version of Roslyn LSP server

* Remove unsupported feature

* Update regexes

* small edits to readme

* deleted extra space in readme

* Try a less recent Razor version

* Update roslyn

---------

Co-authored-by: David Barbet <[email protected]>
Co-authored-by: David Barbet <[email protected]>
Co-authored-by: Joey Robichaud <[email protected]>
Co-authored-by: Joey Robichaud <[email protected]>
Co-authored-by: leslierichardson95 <[email protected]>
Co-authored-by: Manish Vasani <[email protected]>
Co-authored-by: Andrew Wang <[email protected]>
Co-authored-by: David Wengier <[email protected]>
Co-authored-by: Andrew Hall (METAL) <[email protected]>
Co-authored-by: Mika Dumont <[email protected]>
Co-authored-by: Mika Dumont <[email protected]>
Co-authored-by: David Wengier <[email protected]>
arunchndr added a commit that referenced this pull request Jul 18, 2023
@arunchndr @dibarbet
@JoeRobich @leslierichardson95 @mavasani @WardenGnaw @davidwengier @ryzngard @mikadumont @dependabot @isadorasophia
Snap main for C# prerelease 07/17 (#5927)
4491904 
* Increase release CI timeout

* Add CI for release branch

* Add eslint and fix warnings

* Implement report issue command for prerelease extension

* Update O# Roslyn and prepare for release

* Switch to non-deprecated action for asset upload

* Upload all VSIX in one step

* Update .github/workflows/release-ci.yml

Co-authored-by: Joey Robichaud <[email protected]>

* Update release-ci.yml

* review feedback

* use vscode-uri

* Add write permissions to job

* Fix options schema

* Explicitly throw if runtimeId is missing

* Use real looking runtimeId in fake

* Use issue reporter command

* Add server path as an option to allow Razor to re-use the runtime resolver

* Fix brace

* More lint

* Update README.md to notify user about .NET Runtime Tool

* Enable full solution background analysis

- Adds 2 new background analysis scope options: one for compiler diagnostics and one for analyzer diagnostics
- Both the options allow the same set of values as in VS: Open documents, Entire solution, Current document and None (disabled). Currently, `Current document` option is not yet supported in LSP as we do not have a way to know which is the current active document in LSP server.
- Builds on top of dotnet/roslyn#68799
- Needs couple more Roslyn side changes as a follow-up: dotnet/roslyn#68797 and dotnet/roslyn#68798

* Remove the un-supported `Current Document` option

* File renames

* Remove TSLint and configure eslint

* Enable remaining rules from tslint and remove

* Run prettier automatic fixer

* address a couple remaining eslint errors

* Remove incorrectly cased folders

* Remove duplicate license header

* Fix options schema after package.json changes

* Fix chai test assertion library usages

* Avoid using 'solution crawler' terminology in the VSCode option name

* Address feedback and fix test

* Revert unintentional changes from merge

* Some more reverts

* Address feedback and also fix linting issues

* Revert "Merged PR 475885: Add support for F5 for csproj and sln" (#5875)

This reverts commit 173be18.

* Update README.md to make runtime extension note numbered

* Bump Razor to 7.0.0-preview.23328.2

* Allow updatePackageDependencies to work with Razor (well, with prerelease packages)

* Add task for updating Razor deps

* Move to newer version of Roslyn LSP server

* Remove unsupported feature

* Update regexes

* small edits to readme

* deleted extra space in readme

* Try a less recent Razor version

* Update roslyn

* Remove pwa- prefix from BlazorDebug (#5908)

This PR removes pwa- from msedge and chrome as this was an older debug
type that is now depricated.

See microsoft/vscode-js-debug#1305

* Add determineBrowserType to CSharpExtensionExports (#5911)

This PR exports the
BlazorDebugConfigurationProvider.determineBrowserType method that it
could be used in vscode-dotnettools to help determine the browser the
user wants to use.

* Bump semver from 5.6.0 to 5.7.2

Bumps [semver](https://github.com/npm/node-semver) from 5.6.0 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.6.0...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update debugger packages to 2.0.2 (#5914)

Co-authored-by: Isadora Rodopoulos <[email protected]>

* Fix static variables used in determineBrowserType (#5919)

This PR fixes the 'this' to be 'BlazorDebugConfigurationProvider' for
the new static variables from #5911

* Add call to setupTelemetryEnvironmentAsync (#5922)

* Add call to setupTelemetryEnvironmentAsync

* Make optional

* Update Roslyn server (#5925)

* Update Roslyn server

* Update package.json

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: David Barbet <[email protected]>
Co-authored-by: David Barbet <[email protected]>
Co-authored-by: Joey Robichaud <[email protected]>
Co-authored-by: Joey Robichaud <[email protected]>
Co-authored-by: leslierichardson95 <[email protected]>
Co-authored-by: Manish Vasani <[email protected]>
Co-authored-by: Andrew Wang <[email protected]>
Co-authored-by: David Wengier <[email protected]>
Co-authored-by: Andrew Hall (METAL) <[email protected]>
Co-authored-by: Mika Dumont <[email protected]>
Co-authored-by: Mika Dumont <[email protected]>
Co-authored-by: David Wengier <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Isadora <[email protected]>
Co-authored-by: Isadora Rodopoulos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunchndr arunchndr arunchndr approved these changes

@gregg-miskelly gregg-miskelly Awaiting requested review from gregg-miskelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C# extension v2.x introduces new file language association, which breaks several things
2 participants
@WardenGnaw @arunchndr