Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unit test debugging options when attaching to unit test process #6110

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Aug 11, 2023

Part of #5719 (comment)

Tested that various logging, symbol options, etc are able to be modified and respected when debugging unit tests.

@dibarbet dibarbet requested a review from a team as a code owner August 11, 2023 01:12
@dibarbet dibarbet requested a review from Cosifne August 11, 2023 03:36
@dibarbet
Copy link
Member Author

Actually - need to move the options into the dotnet section. Converting to draft.

@dibarbet dibarbet marked this pull request as draft August 11, 2023 03:37
@dibarbet dibarbet marked this pull request as ready for review August 11, 2023 04:45
@@ -1555,6 +1346,215 @@
"description": "Search symbols in reference assemblies. It affects features requires symbol searching, such as add imports.",
"order": 80
},
"dotnet.unitTestDebuggingOptions": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from the O# option section and renamed, let me know if I should keep the same name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine the name if debugger team like this

@dibarbet dibarbet merged commit 7a3ff63 into dotnet:main Aug 11, 2023
@dibarbet dibarbet deleted the unit_test_debug_options branch August 11, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants