Consume per-runtime language servers #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Aug 31, 2023
To keep our package size more manageable, we now create a separate language server package per runtime. This changes our download tasks to adjust for this and updates to a new Roslyn version that has separate packages.
jasonmalinowski
force-pushed
the
consume-separate-language-servers-per-rid
branch
from
6bc81ae
to
02b3b37
Compare
dibarbet
approved these changes
Sep 1, 2023
tasks/offlinePackagingTasks.ts
Outdated
| async function installRoslyn(packageJSON: any, platformInfo?: PlatformInformation) { | ||
| const roslynVersion = packageJSON.defaults.roslyn; | ||
| const packagePath = await acquireNugetPackage('Microsoft.CodeAnalysis.LanguageServer', roslynVersion); | ||
| gulp.task('fetchAllRoslynPlatformPackages', async () => { |
There was a problem hiding this comment.
Can you update the contributing docs to mention that you should run this task to update roslyn instead of the 'installDependencies' task?
There was a problem hiding this comment.
Not only did I update the documentation, I also updated this to run installDependencies after. And renamed it to "updateRoslynVersion" which is just a better name, honestly.
We fetch these from an upstream feed that has authenticated feeds as upstreams of it; this is an easy way to ensure everything is cached properly for all platforms.
jasonmalinowski
force-pushed
the
consume-separate-language-servers-per-rid
branch
from
fff9ea1
to
4ea6193
Compare
dibarbet
approved these changes
Sep 2, 2023
jasonmalinowski
deleted the
consume-separate-language-servers-per-rid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep our package size more manageable, we now create a separate language server package per runtime.
This consumes dotnet/roslyn#69786.