Fix completionComplexEdit: Use fsPath instead of path #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KCFindstr Thanks a lot for the contribution! From a local repro I was finally able to get, the capitalization of windows drive letter is indeed the cause (although I'm not sure why the uri.path of the document we get from editor would vary) 
|
genlu
approved these changes
Sep 8, 2023
This was referenced Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #6011 .
Found that
completionComplexEditshould find editors according tofsPathinstead ofpath, similar to other places.pathmight be different on Windows, e.g.uri.path:
editor.document.uri.path:
After this fix, the autocomplete works properly with mouse clicks / tab autocomplete. However, it still does not respond to enter key (it simply adds a new line instead of inserting the autocompletion).