Update language server to use named pipe client #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccamc
commented
Sep 12, 2023
beccamc
changed the title
beccamc
changed the title
dibarbet
reviewed
Sep 12, 2023
|
|
||
| // Wait for the server to send back the name of the pipe to connect to. | ||
| _channel.appendLine('waiting for named pipe information from server...'); | ||
| const pipeConnectionInfo = await namedPipeConnectionPromise; |
There was a problem hiding this comment.
we should probably add a timeout here and show an error toast if it times out.
There was a problem hiding this comment.
Yes that's a good idea. Should probably do it for both receiving the name and making the named pipe connection
There was a problem hiding this comment.
Updated to throw an error, which will log. The "couldn't create connection" toast will show.
dibarbet
reviewed
Sep 13, 2023
dibarbet
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current communication between client and server is writing to STDOUT. This makes the connection vulnerable to any code in the process writing to stdout stream and corrupting the data.
This PR uses a named pipe...
NOTE: Need server PR to go in and then update the server version in this PR.
This has been tested on both windows and mac.