[Razor] Textmate colorization fixes #6514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is less of a fix and more of a hack. I spent a significant amount of time the past few days trying to fix this the proper way - i.e., making major changes to Razor's Textmate grammar - but it was incredibly frustrating and there were edge cases that kept popping up. This solution fixes the problem without a huge investment but makes some compromises.
Problem:
=>
and"
as possible valid syntax in component attributes. But because of how buggy our Razor Textmate grammar already is, this turned out to be a much more difficult task than expected, hence the simplified solution in this PR.Solution:
Before example:
After example: