Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nested code actions to csharp extension #6572

Merged
merged 13 commits into from
Nov 17, 2023
Merged

Add nested code actions to csharp extension #6572

merged 13 commits into from
Nov 17, 2023

Conversation

akhera99
Copy link
Member

@akhera99 akhera99 commented Oct 20, 2023 •
edited
Loading

  • Iterates through nested code actions after a top-level code action selection has been made
  • Opens a quick pick for the nested code actions
  • Sends either a CodeActionResolveRequest or a CodeActionFixAllResolveRequest based on the selected item
  • Applies the edit
NestedCodeActions_vscode.mp4

@akhera99 akhera99 marked this pull request as ready for review October 30, 2023 19:55
@akhera99 akhera99 requested a review from a team as a code owner October 30, 2023 19:55
dibarbet
dibarbet reviewed Oct 31, 2023
View reviewed changes
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
dibarbet
dibarbet reviewed Nov 13, 2023
View reviewed changes
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Show resolved Hide resolved
src/lsptoolshost/nestedCodeAction.ts Outdated Show resolved Hide resolved
@akhera99 akhera99 merged commit c68964c into dotnet:main Nov 17, 2023
13 checks passed
@dibarbet dibarbet mentioned this pull request Dec 6, 2023
Closed
@SeijiSuenaga SeijiSuenaga mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich left review comments

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhera99 @JoeRobich @dibarbet