Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange the settings sections into actual categories #6652

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

333fred
Copy link
Member

@333fred 333fred commented Nov 9, 2023

This puts settings into discrete categories (I chose "Editor Behavior", "Debugger", "LSP Server", and "OmniSharp") so that our settings can be reasonably navigated by a human, rather than being a giant blob that cannot be properly viewed.

This puts settings into discrete categories (I chose "Editor Behavior", "Debugger", "LSP Server", and "OmniSharp") so that our settings can be reasonably navigated by a human, rather than being a giant blob that cannot be properly viewed.
@333fred 333fred requested a review from a team as a code owner November 9, 2023 18:45
@333fred
Copy link
Member Author

333fred commented Nov 9, 2023

Here's what this looks like:
image

Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change. FYI @mikadumont in case she has any thoughts on the grouping or naming.

test/unitTests/configurationMiddleware.test.ts Outdated Show resolved Hide resolved
test/unitTests/migrateOptions.test.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@333fred 333fred enabled auto-merge (squash) November 9, 2023 22:42
@333fred 333fred merged commit 089faf8 into dotnet:main Nov 9, 2023
13 checks passed
@333fred 333fred deleted the settings-categories branch November 9, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants