Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger docs: point to official docs #6674

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

gregg-miskelly
Copy link
Contributor

This PR updates the debugger docs to just point at the official documentation rather than duplicating their content.

Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we hold off on merging this change until we release a version of the extension with #6659 ?

Seems like the strings in the current released extension point to these files

@gregg-miskelly
Copy link
Contributor Author

Should we hold off on merging this change until we release a version of the extension with #6659 ?

It's required because the aka.ms links point at the release branch's copy of the docs. Though maybe we should do it anyway just in case.

This PR updates the debugger docs to just point at the official documentation rather than duplicating its content.
@gregg-miskelly
Copy link
Contributor Author

@davidwengier I am having trouble getting the test:razorintegration:BasicRazorApp2_1 test to pass on macOS. Are you the right person to take a look? I have re-run the test ~5 times now without success. This PR doesn't contain code changes, so I don't see how it could be related.

From the log, I think this is the first failure:

2023-11-30T22:00:25.4986430Z   console.log
2023-11-30T22:00:25.5000690Z     Extension Log Directory: /Users/runner/work/1/s/.vscode-test/user-data/logs/20231130T220005/window1/exthost/ms-dotnettools.csharp
2023-11-30T22:00:25.5015900Z 
2023-11-30T22:00:25.5039880Z       at Object.<anonymous> (../integrationTests/integrationHelpers.ts:42:13)
2023-11-30T22:00:25.5059810Z 
2023-11-30T22:00:33.6904980Z MainThreadFileSystemEventService#$watch(): failed to stat a resource for file watching (extension: ms-dotnettools.csharp, path: file:///usr/local/share/dotnet/packs/, recursive: true, session: 0.1325660403686899): EntryNotFound (FileSystemError): Error: ENOENT: no such file or directory, stat '/usr/local/share/dotnet/packs/'
2023-11-30T22:00:34.7766350Z FAIL Razor Integration Tests test/razorIntegrationTests/formatting.integration.test.ts (15.65 s)

@davidwengier
Copy link
Contributor

I wrote the test, but it doesn't do anything different to other integration tests that would cause it to trigger the error being reported in the test output:

Error: Stopping the server timed out
    at /Users/runner/work/1/s/node_modules/vscode-languageclient/lib/common/client.js:971:23
    at s.async [as restart] (/Users/runner/work/1/s/node_modules/vscode-languageclient/lib/node/main.js:135:5)

The Error: ENOENT: no such file or directory, stat '/usr/local/share/dotnet/packs/' appears to be a red herring, as its also present in the output for the test immediately preceding the formatting test. Though I wouldn't have thought the formatting test could cause that either :)

Feel free to skip it if it never turns green

@gregg-miskelly
Copy link
Contributor Author

@davidwengier @dibarbet is there actually a way to skip tests?

@davidwengier
Copy link
Contributor

@gregg-miskelly I believe to skip you change test to test.skip here: https://github.com/dotnet/vscode-csharp/blob/main/test/razorIntegrationTests/formatting.integration.test.ts#L31

But looks like you have green builds now 🤷‍♂️

@gregg-miskelly gregg-miskelly merged commit 0b41c68 into dotnet:main Dec 4, 2023
13 checks passed
@gregg-miskelly gregg-miskelly deleted the RedirectDebuggerDocs branch December 4, 2023 21:16
Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants