Add Razor inlay hint and inlay hint resolve handlers #6857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgav
reviewed
Feb 6, 2024
|
|
||
| const virtualCSharpUri = UriConverter.serialize(razorDocument.csharpDocument.uri); | ||
|
|
||
| const roslynInlayHintParams = <InlayHintParams>{ |
There was a problem hiding this comment.
For my understanding - why do we not need to do this for the resolve request?
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Feb 6, 2024
Adds inlay hint support for Razor in VS and VS Code, cohosting and regular. Goes with dotnet/vscode-csharp#6857 for the VS Code side.
|
Ping @dotnet/roslyn-ide for reviews, if you please :) |
dibarbet
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with dotnet/razor#9904 for the server side.
Obviously needs a Razor bump to actually work, but that is blocked at the moment anyway.