Do not timeout on connecting to the server if waitForDebugger is set #6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Mar 13, 2024
|
|
||
| const connectionPromise = new Promise<net.Socket>((resolveConnection, rejectConnection) => { |
There was a problem hiding this comment.
created an overall connection promise to wrap the named pipe and socket connection steps. Allows me to move the child process on exit handling from the timeout promise to the connection promise
arunchndr
approved these changes
Mar 13, 2024
ryzngard
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit a few people while debugging - the pipe connection would time out while debugging was on-going.
This modifies the socket connection code to not timeout if the waitForDebugger option is set. Also cleans up a bit of the code that handles unexpected process exit.