Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roslyn #7011

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Update roslyn #7011

merged 3 commits into from
Mar 29, 2024

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Mar 29, 2024

Updates Roslyn to https://dnceng.visualstudio.com/internal/_build/results?buildId=2418271&view=results

Also adds support for the obsolete classification in the default themes:
image

@dibarbet dibarbet requested a review from a team as a code owner March 29, 2024 22:34
@dibarbet dibarbet merged commit 0e9009d into dotnet:main Mar 29, 2024
11 checks passed
@lonix1
Copy link

lonix1 commented May 8, 2024

Just updated to latest bits, but this doesn't work for me. Is there a setting one should use?

@dibarbet
Copy link
Member Author

dibarbet commented May 8, 2024

Just updated to latest bits, but this doesn't work for me. Is there a setting one should use?

@lonix1 if you are not using the vs2019 dark or light themes that we ship with the extension, you may have to add the following to your settings.json:

"editor.semanticTokenColorCustomizations": {
    "rules": {
        "*.deprecated": {
            "strikethrough": true
        }
    },
}

Potentially we can consider adding a configurationDefaults to our package.json so it would automatically apply to any theme being used.

If you are using the vs2019 theme and it isn't working, please file an issue and share a screenshot of running the 'Inspect Editor token and scopes' command on an obsolete method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants