Add missing env to GetUnixArchitecture

[Elias-Graf]

Add missing environment when acquiring the UNIX architecture. Not providing the environment, breaks systems that don't have uname in the $PATH by default, such as NixOS. Demonstrated by this issue: #5575.

Personally, I would also recommend removing the default value for the env parameter, forcing the programmer to think about their intention, instead of just leaving it out.

vscode-csharp/src/common.ts

Line 62 in 7682992

env: NodeJS.ProcessEnv = {}

If that is something you are interested in, let me know, and I will adjust the function, and necessary call sites. There don't appear to be too many.

Fixes #5575.

[dibarbet]

Apologies for the delay here. Generally I think I'm good with the change. I do worry a little that we might break some edge scenario where an incorrect env var breaks this, but I think the answer there is to fix the env var.

Personally, I would also recommend removing the default value for the env parameter, forcing the programmer to think about their intention, instead of just leaving it out.

Yup, I think that would be a good idea. Would be happy to accept that change. I'm good to merge as-is as well if you'd prefer to not do it now.

[Elias-Graf]

@dibarbet Thank you for looking at the pull request.
I have now removed the default value for the env variable. I have provided process.env in all cases, as it seemed appropriate.
Due to the second to last variable also being optional, I had to remove the default value of the workingDirectory as well. I had also considered reordering the parameters, but given that the workingDirectory is always provided anyway, I've decided against it. In addition, the order seems more natural in the current state. Feel free to request further changes.

I do worry a little that we might break some edge scenario where an incorrect env var breaks this, but I think the answer there is to fix the env var.

That is always a risk with changes considering "user input". Although given that not passing along the environment in most cases is probably wrong, and most definitely problematic in the affected cases, it is also not fixable by the user in any obvious way - while a broken environment definitely is.

@dotnet-policy-service agree

[dibarbet]

Thanks for the contribution!