Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace status item to the Language Status bar. #7254

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Jun 21, 2024

This makes a little progress on #6675. It shows a work indicator for the initial workspace load. It will also show the open solution file name and provides a link for users to open a different solution. This does not move NuGet restore to the server nor does it show progress when reloading projects.

Project.Status.mp4

Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally good with this as the first part!

import { ServerState } from './serverStateChange';
import { getCSharpDevKit } from '../utils/getCSharpDevKit';

export function registerLanguageStatusItems(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant for this PR, but something to check when we do TFMs - can two different extensions register language status items for the same language? Devkit does have a language status item (launch.json stuff).

@JoeRobich JoeRobich merged commit 6ce956b into main Jul 9, 2024
13 checks passed
@JoeRobich JoeRobich deleted the dev/jorobich/workspace-status-item branch October 8, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants